Wait until PDFDocumentLoadingTask.destroy is resolved before calling done in the API unit-tests
#8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g `done` in the API unit-tests Try to ensure that everything, including workers, are properly destroyed before running the next test-case.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/80da8bf387c4c39/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/da99e4394ebad2a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/80da8bf387c4c39/output.txt Total script time: 2.22 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/da99e4394ebad2a/output.txt Total script time: 7.26 mins
|
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…-destroy Wait until `PDFDocumentLoadingTask.destroy` is resolved before calling `done` in the API unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to ensure that everything, including workers, are properly destroyed before running the next test-case.
Please note: Even though this didn't magically fix the timeouts in PR #8284, it's still conceptually the right thing to do which is why I figured that I'd submit this PR.