-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully ignore transaction failure in plugin-babel-cached #8406
Gracefully ignore transaction failure in plugin-babel-cached #8406
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a66ab426fd42981/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a66ab426fd42981/output.txt Total script time: 2.03 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/41f62a9c72c697e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b9442ecdaf24d03/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b9442ecdaf24d03/output.txt Total script time: 20.94 mins
Image differences available at: http://54.67.70.0:8877/b9442ecdaf24d03/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/41f62a9c72c697e/output.txt Total script time: 25.74 mins
|
Looks good, thank you! |
Gracefully ignore transaction failure in plugin-babel-cached
Before this PR, any DB transaction error prevents the plugin from completing. Since the cache is a best-efforts attempt, I fix this by ignoring the error (instead of rethrowing the error).