Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully ignore transaction failure in plugin-babel-cached #8406

Merged
merged 1 commit into from
May 14, 2017

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented May 14, 2017

Before this PR, any DB transaction error prevents the plugin from completing. Since the cache is a best-efforts attempt, I fix this by ignoring the error (instead of rethrowing the error).

@Rob--W Rob--W added the other label May 14, 2017
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a66ab426fd42981/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/a66ab426fd42981/output.txt

Total script time: 2.03 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/41f62a9c72c697e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b9442ecdaf24d03/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/b9442ecdaf24d03/output.txt

Total script time: 20.94 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/b9442ecdaf24d03/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/41f62a9c72c697e/output.txt

Total script time: 25.74 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 08f8b68 into mozilla:master May 14, 2017
@timvandermeij
Copy link
Contributor

Looks good, thank you!

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Gracefully ignore transaction failure in plugin-babel-cached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants