Remove the special handling for nameddests that look like standard pageNumbers
#8432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pageNumbers PR 7341 added special handling for `nameddest`s that look like pageNumbers, to prevent issues since we previously *incorrectly* supported specifying a pageNumber directly in the hash; i.e. `#10` versus the correct `#page=10` format. Since this behaviour wasn't correct, PR 7757 fixed and deprecated the old format, which means that we no longer need to maintain the `nameddest` hack in multiple files.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/24adedb9b955f40/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/65f8ee422562efb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/24adedb9b955f40/output.txt Total script time: 2.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/65f8ee422562efb/output.txt Total script time: 4.90 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ac288b30b7f4e9b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ac288b30b7f4e9b/output.txt Total script time: 2.05 mins Published |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Remove the special handling for `nameddest`s that look like standard pageNumbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7341 added special handling for
nameddests that look like pageNumbers, to prevent issues since we previously incorrectly supported specifying a pageNumber directly in the hash; i.e.#10versus the correct#page=10format.Since this behaviour wasn't correct, PR #7757 fixed and deprecated the old format, which means that we no longer need to maintain the
nameddesthack in multiple files.