-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424) #8436
Conversation
…e 8424) *This patch follows a similar pattern as previous ones, by skipping certain problematic Unicode locations.* According to http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/harfbuzz/src/hb-unicode-private.hh#136, it seems that the HANGUL FILLER (0x3164) location is "special". Fixes 8424.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/52834de3eac602e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e3ba55bc873e539/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e3ba55bc873e539/output.txt Total script time: 24.45 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/52834de3eac602e/output.txt Total script time: 24.88 mins
|
/botio makeref Thank you for the patch. |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://54.67.70.0:8877/8dbfa495e2969de/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://54.215.176.217:8877/ddb1d2eaf1ae810/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ddb1d2eaf1ae810/output.txt Total script time: 23.16 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8dbfa495e2969de/output.txt Total script time: 23.58 mins
|
Excuse my ignorance about the code, but why not map the glyphs to one of the private use areas which are guaranteed not to have any special properties? Each of Supplemental Private Use Area-A and B is big enough to cover all glyphs in a given font file. |
That's right -- we move such characters to Private Use Area. |
Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424)
This patch follows a similar pattern as previous ones, by skipping certain problematic Unicode locations.
According to http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/harfbuzz/src/hb-unicode-private.hh#136, it seems that the HANGUL FILLER (0x3164) location is "special".
Fixes #8424.