Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424) #8436

Merged
merged 1 commit into from
May 23, 2017
Merged

Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424) #8436

merged 1 commit into from
May 23, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

This patch follows a similar pattern as previous ones, by skipping certain problematic Unicode locations.

According to http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/harfbuzz/src/hb-unicode-private.hh#136, it seems that the HANGUL FILLER (0x3164) location is "special".

Fixes #8424.

…e 8424)

*This patch follows a similar pattern as previous ones, by skipping certain problematic Unicode locations.*

According to http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/harfbuzz/src/hb-unicode-private.hh#136, it seems that the HANGUL FILLER (0x3164) location is "special".

Fixes 8424.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/52834de3eac602e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e3ba55bc873e539/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/e3ba55bc873e539/output.txt

Total script time: 24.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/52834de3eac602e/output.txt

Total script time: 24.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik
Copy link
Contributor

/botio makeref

Thank you for the patch.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 1

Live output at: http://54.67.70.0:8877/8dbfa495e2969de/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 1

Live output at: http://54.215.176.217:8877/ddb1d2eaf1ae810/output.txt

@yurydelendik yurydelendik merged commit ad797fa into mozilla:master May 23, 2017
@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/ddb1d2eaf1ae810/output.txt

Total script time: 23.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/8dbfa495e2969de/output.txt

Total script time: 23.58 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-8424 branch May 23, 2017 17:25
@khaledhosny
Copy link

khaledhosny commented May 23, 2017

Excuse my ignorance about the code, but why not map the glyphs to one of the private use areas which are guaranteed not to have any special properties? Each of Supplemental Private Use Area-A and B is big enough to cover all glyphs in a given font file.

@yurydelendik
Copy link
Contributor

Excuse my ignorance about the code, but why not map the glyphs to one of the private use areas

That's right -- we move such characters to Private Use Area.

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Don't map glyphs to the HANGUL FILLER (0x3164) Unicode location (issue 8424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants