Ensure that TilingPatterns have valid (non-zero) /BBox arrays (issue 8330)
#8441
Conversation
|
/botio-linux unittest |
|
Checking if the test "failures" in Chrome on Windows is intermittent. /botio-windows test |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/efcb466db8d8c5f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6bc3ee4e9d25bba/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/efcb466db8d8c5f/output.txt Total script time: 17.05 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/6bc3ee4e9d25bba/output.txt Total script time: 29.47 mins
Image differences available at: http://54.215.176.217:8877/6bc3ee4e9d25bba/reftest-analyzer.html#web=eq.log |
src/core/pattern.js
Outdated
|
|
||
| // Ensure that the pattern has a non-zero width and height, to prevent errors | ||
| // in `pattern_helper.js` (fixes issue8330.pdf). | ||
| assert((bbox[2] - bbox[0]) !== 0 && (bbox[3] - bbox[1]) !== 0, |
There was a problem hiding this comment.
(it's pre-existing practice but) let's change this to if..throw new Error. I'll will be opening issue to re-inspect assert usage (see #8506)
There was a problem hiding this comment.
Sure, I've updated the patch; thank you for the review!
…e 8330) Fixes 8330.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4016fb84ebfa052/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ee6fd093bc65d99/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4016fb84ebfa052/output.txt Total script time: 16.97 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ee6fd093bc65d99/output.txt Total script time: 29.88 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/36c0d875c294f8b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cb0dbeea75d44df/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/36c0d875c294f8b/output.txt Total script time: 15.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cb0dbeea75d44df/output.txt Total script time: 28.17 mins
|
Ensure that `TilingPattern`s have valid (non-zero) /BBox arrays (issue 8330)
Fixes #8330.
Please note: This is a tentative patch, since I'm not entirely certain if it's the best solution; but it does work!