-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes last UMDs from the modules. #8462
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/13e57b5cfaeed0e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/13e57b5cfaeed0e/output.txt Total script time: 2.05 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b48a93f0432bf0e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/c06b300cd5c2086/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b48a93f0432bf0e/output.txt Total script time: 17.39 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the inline question, is there any reason for not updating https://github.com/mozilla/pdf.js/blob/master/src/pdf.js to the same format as is now used in src/main_loader.js
?
This looks good to me, thank you!
displayTextLayer, displayDOMUtils, sharedUtil, | ||
displaySVG, displayGlobal) { | ||
|
||
// Sync the exports below with ./pdf.js file/template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something, shouldn't we keep this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove main_loader.js
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/c06b300cd5c2086/output.txt Total script time: 29.34 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8fce3296f70488a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8fce3296f70488a/output.txt Total script time: 2.08 mins Published |
Removes last UMDs from the modules.
No description provided.