Allow specifying the PDFJS_NEXT build flag via an environment variable when running the various gulp commands
#8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
PDFJS_NEXT build flag via an environment variable when running the various `gulp´ commandsPDFJS_NEXT build flag via an environment variable when running the various gulp commands
yurydelendik
approved these changes
May 31, 2017
…ble when running the various `gulp` commands After PR 8459, the run-time of the various `gulp` test commands has regressed quite badly on Windows. For me, `gulp test` now takes approximately *twice* as long when run locally on Windows. The problem seems to be the Babel transpilation step, which takes well over five minutes to run.[1] For someone like me, who runs tests a lot locally, this slowdown is really hurting the overall development experience. To get around this I tested setting `PDFJS_NEXT = true` in `gulpfile.js`, since the transpilation step isn't necessary when testing in a modern browser. However, having to edit `gulpfile.js` every time that I need to run tests isn't very practical. Hence this patch, which adds an environment variable that allows you to disable the transpilation simply by using e.g. `PDFJS_NEXT=true gulp test`. I hope that this can be considered an acceptable solution, such that I don't need to maintain this patch locally (or worse, edit `gulpfile.js` locally before testing). --- [1] This can also be observed on the Windows bot, but it seems fine on Linux.
That's a lot better, fixed now, thanks! /botio-linux lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1fc7c6f10249f9b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1fc7c6f10249f9b/output.txt Total script time: 0.96 mins
|
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Allow specifying the `PDFJS_NEXT` build flag via an environment variable when running the various `gulp` commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #8459, the run-time of the various
gulptest commands has regressed quite badly on Windows. For me,gulp testnow takes approximately twice as long when run locally on Windows.The problem seems to be the Babel transpilation step, which takes well over five minutes to run.[1]
For someone like me, who runs tests a lot locally, this slowdown is really hurting the overall development experience.
To get around this I tested setting
PDFJS_NEXT = trueingulpfile.js, since the transpilation step isn't necessary when testing in a modern browser.However, having to edit
gulpfile.jsevery time that I need to run tests isn't very practical. Hence this patch, which adds an environment variable that allows you to disable the transpilation simply by using e.g.PDFJS_NEXT=true gulp test.I hope that this can be considered an acceptable solution, such that I don't need to maintain this patch locally (or worse, edit
gulpfile.jslocally before testing).[1] This can also be observed on the Windows bot, but it seems fine on Linux.