Stop tracking the rotation in PDFViewerApplication and directly use PDFViewer.pagesRotation instead
#8556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `PDFViewer.pagesRotation` instead Part of the rotation handling code, in what's now `web/app.js`, hasn't really changed since before the viewer was split into multiple files/components. Similar to other properties, such as current page/scale, we should probably avoid tracking state in multiple places. Hence I'm suggesting that we don't store the rotation in `PDFViewerApplication`, and access the value in `PDFViewer` instead. Since `PDFViewerApplication.pageRotation` has existed for a very long time, a getter was added to avoid outright breaking third-party code that may depend on it.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e15e264b3b46221/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e15e264b3b46221/output.txt Total script time: 2.31 mins Published |
timvandermeij
approved these changes
Jun 21, 2017
|
Thank you for improving this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…ation Stop tracking the rotation in `PDFViewerApplication` and directly use `PDFViewer.pagesRotation` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the rotation handling code, in what's now
web/app.js, hasn't really changed since before the viewer was split into multiple files/components.Similar to other properties, such as current page/scale, we should probably avoid tracking state in multiple places. Hence I'm suggesting that we don't store the rotation in
PDFViewerApplication, and access the value inPDFViewerinstead.Since
PDFViewerApplication.pageRotationhas existed for a very long time, a getter was added to avoid outright breaking third-party code that may depend on it.