Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-7452 name change #8633

Closed
wants to merge 1 commit into from
Closed

Issue-7452 name change #8633

wants to merge 1 commit into from

Conversation

nish17
Copy link
Contributor

@nish17 nish17 commented Jul 10, 2017

I have made all the necessary changes

@Rob--W
Copy link
Member

Rob--W commented Jul 10, 2017

(I am mentoring this bug)

Please do not make more changes than necessary. That does not only complicate review, but it also makes it more difficult to follow the line history (git blame). The easiest fix in this case (since the actual patch is only 4 changes) is to:

  1. Discard the last commit, git reset --hard HEAD^ (this throws away the last commit).
  2. Edit the files to make the four changes
  3. Create a commit with a commit message that briefly describes the commit. For example, "Use consistent labels in the Page fit/width option". In Git it is common to choose a description of at most 50 characters.
    (If needed, you can add a more detailed multi-line description in the following lines, word-wrapped at 72 characters per line. This commit is so simple that no further explanation is needed though).
  4. Force-push the change on your current local branch to the remote branch (i.e. put your changes on Github):
    git push -f origin master (master is the branch name that you used for the remote branch). Github will automatically detect changes on the remote branch and update this pull request.

Tips:

And I see that you're directly working on the master branch. While this works, it is better to work on a separate branch. This makes it easier for you to work on multiple features at the same time, see chapter 3 of the Git book (https://git-scm.com/book/en/v2 ("Git Branching")).

When you create a pull request to fix a known issue, reference the relevant issues to help reviewers with understanding the purpose of the patch. For example, "Fixes #7452". Github will see this bug reference and automatically add a link to the original issue, and if this PR is merged, close the original issue.
If there is no bug report, or if the patch is non-trivial, describe the objective of your pull request.

Show the steps that you have followed to demonstrate that the patch works. This can be in the form of unit tests (in code), or as the steps of a manual test that shows that the behavior changes in a good way.

@Rob--W
Copy link
Member

Rob--W commented Jul 13, 2017

Closing in favor of #8634.

@Rob--W Rob--W closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants