Update the gulp minified command to use uglify-es
#8831
Conversation
gulpfile.js
Outdated
|
|
||
| console.log(); | ||
| console.log('### Minifying js files'); | ||
|
|
||
| var UglifyJS = require('uglify-js'); | ||
| var UglifyJS = require('uglify-es'); |
There was a problem hiding this comment.
I think this should be UglifyES. If you want to avoid that, you can also choose uglifier as a more generic name.
There was a problem hiding this comment.
Sure, will do.
| ]; | ||
| var pdfFile = fs.readFileSync(MINIFIED_DIR + '/build/pdf.js').toString(); | ||
| var pdfWorkerFile = | ||
| fs.readFileSync(MINIFIED_DIR + '/build/pdf.worker.js').toString(); |
There was a problem hiding this comment.
I think we should use BUILD_DIR here and in the other parts of this patch to not hardcode that and to be consistent with other places in the Gulpfile.
There was a problem hiding this comment.
I was just moving existing code around, but I suppose it wouldn't hurt to change this :-)
Edit: Actually, looking through the rest of gulpfile.js, it seems to (almost) exclusively be used when defining other constants, so I'm now not so sure if we really ought to be using it "the other way around" here!?
Lines 46 to 58 in 7cc7260
By updating to uglify-es, rather than uglify-js, the minifier *itself* now supports ES6 code. This means that it's now possible to minify code built with `PDFJS_NEXT = true` set, i.e. with Babel transpilation disabled, which wasn't the case previously. Note that uglify-es is based on the API of uglify-js v3, which differs from the one that we previously used. Of particular importance is the fact that it's no longer possible to provide a path to a file for minification, but one must instead directly provide the source of the file. For more information, please see https://github.com/mishoo/UglifyJS2/tree/harmony
|
Works fine, thank you! |
Update the `gulp minified` command to use uglify-es
By updating to uglify-es, rather than uglify-js, the minifier itself now supports ES6 code. This means that it's now possible to minify code built with
PDFJS_NEXT = trueset, i.e. with Babel transpilation disabled, which wasn't the case previously.Note that uglify-es is based on the API of uglify-js v3, which differs from the one that we previously used.
Of particular importance is the fact that it's no longer possible to provide a path to a file for minification, but one must instead directly provide the source of the file.
For more information, please see https://github.com/mishoo/UglifyJS2/tree/harmony