Correctly set the credentials of a fetch request, when the withCredentials parameter was passed to getDocument
#8848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentials` parameter was passed to `getDocument` Skimming through https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Sending_a_request_with_credentials_included, it looks to me like the `credentials` option was accidentally inverted.
|
The logic is good, but tests are needed to avoid regressions. I noticed this regression when I wanted to run the test case for #8804 (which worked before the fetch feature landed). I'll continue with writing the test case (since I started already) and see how I can attach the commit to this PR (I've seen other repositories with multiple commits from different authors, so that should be possible, I guess). |
|
I'm going to merge this because I don't see a way to open a PR that depends on this, or attach another commit to this PR (I would need write access to your branch). |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Correctly set the `credentials` of a fetch request, when the `withCredentials` parameter was passed to `getDocument`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skimming through https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Sending_a_request_with_credentials_included, it looks to me like the
credentialsoption was accidentally inverted.@yurydelendik If I've completely misunderstood this code, and the MDN docs, please just close this PR (and sorry about wasting your time in that case).