Add test for withCredentials option #8855
Conversation
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Rob--W received. Current queue size: 1 Live output at: http://54.215.176.217:8877/1e4ae32518fb22e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Rob--W received. Current queue size: 1 Live output at: http://54.67.70.0:8877/900ce81c2b17981/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/900ce81c2b17981/output.txt Total script time: 2.56 mins
|
test/unit/api_spec.js
Outdated
| it('server allows cors without credentials, and withCredentials=false', | ||
| function(done) { | ||
| testCanLoad('basicapi.pdf?cors=withoutCredentials', { | ||
| withoutCredentials: false, |
There was a problem hiding this comment.
Nit: Is this supposed to read withCredentials: false, instead, given the test name?
There was a problem hiding this comment.
Fixed, thanks. The current default is also withCredentials: false, so the misspelled name doesn't affect the test result.
Rob--W
force-pushed
the
fetch-withCredentials-fix-default
branch
from
160704f to
73273cc
Compare
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/1e4ae32518fb22e/output.txt Total script time: 0.20 mins |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2ae9bc29b05ac6c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b03a5e8f69a9185/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2ae9bc29b05ac6c/output.txt Total script time: 16.52 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/b03a5e8f69a9185/output.txt Total script time: 29.34 mins
Image differences available at: http://54.215.176.217:8877/b03a5e8f69a9185/reftest-analyzer.html#web=eq.log |
|
This a unittest-only change, so the failure in the non-unit tests are obviously not caused by this PR. Most of my recent test runs for other patches failed tests on Windows. The noise is a bit distracting, is something being done against that? |
|
@Rob--W Most of them are fixed, but only the person with dog PDF remains intermittent on Windows. I'd say just ignore that one for now; if it last a long time, we can always decide to temporarily disable it. Thank you for providing this unit test! |
…-default Add test for withCredentials option
Add unit test to avoid regressing on #8848.
Locally, I verified that without #8848, some of the new tests fail.
With #8848 (which has been merged), all added tests pass.