Use the SimpleLinkService when running "annotations" reference tests
#8900
Conversation
Rather than (basically) duplicating the `SimpleLinkService` in `test/driver.js`, with potential test failuires if you forget to update the test mock, it seems much nicer to just re-use the viewer component. Note that `SimpleLinkService` is already bundled into the `build/components/pdf_viewer.js` file. Hence we only need to expose it similar to the other viewer components in that file, and make sure that the `gulp components` command runs as part of the test-setup.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1cf199f060a4258/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9c8f8c1ebe9f37a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1cf199f060a4258/output.txt Total script time: 16.76 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9c8f8c1ebe9f37a/output.txt Total script time: 31.56 mins
|
|
The commit itself looks good, but I'm worried about the increase in time on the Windows bot. I saw before that, while it takes only a few seconds to run Webpack on the Linux bot, it takes up to 10 minutes on the Windows bot. This commit adds an extra Webpack step, thereby increasing the time with such an amount. I think we should figure out what the problem is on the Windows bot first. I had hoped updating Webpack to the latest version would help, but unfortunately it did not change anything. @yurydelendik Would you be able to help out here? Do you know what may cause the Windows bot to be so slow with Webpack? I have no idea what it could possibly be doing for 10 minutes... |
I'm not convinced that the added Furthermore, it's not actually Webpack that's slow on Windows. Instead, it's Babel which takes a long time to run. Locally on Windows, I'm running all tests with |
I agree. The bots run the most recent Firefox and Chrome versions, so there should be no need for the transpilation step. Could you add a commit to disable that so we can do a new test run and see if it helps? |
The changes would need to be done at https://github.com/mozilla/botio-files-pdfjs, and then pushed to the bots manually. I'll see about submitting a PR for that tomorrow! In the meantime, I'll trigger a new round of testing to check that the Windows bot wasn't just temporarily slow when the tests ran earlier today. |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5a8f433c89d5d22/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/25a26a45c0e3c18/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5a8f433c89d5d22/output.txt Total script time: 16.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/25a26a45c0e3c18/output.txt Total script time: 29.44 mins
|
It seems to have been just a temporary problem, since the runtime of the Windows bot is now back to its usual value. Edit: See also mozilla/botio-files-pdfjs#19. |
|
Thank you for improving this! Good to know that the runtime is not a new issue. The other patch will hopefully improve the runtime. |
…kService Use the `SimpleLinkService` when running "annotations" reference tests
Rather than (basically) duplicating the
SimpleLinkServiceintest/driver.js, with potential test failuires if you forget to update the test mock, it seems much nicer to just re-use the viewer component.Note that
SimpleLinkServiceis already bundled into thebuild/components/pdf_viewer.jsfile. Hence we only need to expose it similar to the other viewer components in that file, and make sure that thegulp componentscommand runs as part of the test-setup.