Ignore 'change' events that didn't originate in the viewer (issue 8915) #8919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather that registering a 'change' event listener on the `window`, which will thus (unnecessarily) fire in *a number* of other situations such as e.g. when the user changes the pageNumber or the current search term, we could/should just register it directly on the dynamically created `fileInput` DOM element instead. I can see no really compelling reason why we actually need to listen for `file` changes on the `window` itself, and this way we're also able to keep the `fileInput` related code confined to one part of the code which should aid readability. Furthermore, in custom deployments, there's less risk that we're going to interfere with "outside" code this way. Finally, preprocessor guards were added to the `webViewerOpenFile` function, since that code doesn't make sense in e.g. the extension builds.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/72cc47020b8cdbb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/72cc47020b8cdbb/output.txt Total script time: 2.52 mins Published |
timvandermeij
approved these changes
Sep 17, 2017
|
Thank you for fixing this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Ignore 'change' events that didn't originate in the viewer (issue 8915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather that registering a 'change' event listener on the
window, which will thus (unnecessarily) fire in a number of other situations such as e.g. when the user changes the pageNumber or the current search term, we could/should just register it directly on the dynamically createdfileInputDOM element instead.I can see no really compelling reason why we actually need to listen for
filechanges on thewindowitself, and this way we're also able to keep thefileInputrelated code confined to one part of the code which should aid readability.Furthermore, in custom deployments, there's less risk that we're going to interfere with "outside" code this way.
Finally, preprocessor guards were added to the
webViewerOpenFilefunction, since that code doesn't make sense in e.g. the extension builds.Fixes #8915.