Update all packages to the most recent version #8977
Conversation
|
/botio test |
| @@ -152,7 +152,7 @@ function createWebpackConfig(defines, output) { | |||
| loader: 'babel-loader', | |||
| exclude: /src\/core\/(glyphlist|unicode)/, // babel is too slow | |||
| options: { | |||
| presets: pdfjsNext ? undefined : ['es2015'], | |||
| presets: pdfjsNext ? undefined : ['env'], | |||
There was a problem hiding this comment.
The same change must be made at https://github.com/timvandermeij/pdf.js/blob/98b9d5ec37398bcd1eeb784f2b220f57bb9cabb8/gulpfile.js#L1002 as well.
There was a problem hiding this comment.
Done in the new commit.
timvandermeij
force-pushed
the
updates
branch
from
98b9d5e to
3d4e48b
Compare
To support this, the following changes have to be made as well: - Ignore `package-lock.json` since NPM creates it, but we should not have it in the repository. - Switch from `babel-preset-es2015` to `babel-preset-env` to resolve the deprecation warning in the test logs. The latter is more recent and flexible, but should be the same functionality-wise. - `transform` now needs to have the `utf-8` encoding option provided. If not given, it will call the callback with a `Buffer` object, which results in an unhandled promise rejection since what is returned from the callback is a string, not a `Buffer`.
timvandermeij
force-pushed
the
updates
branch
from
3d4e48b to
0733b54
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4339bc991ba5b35/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4339bc991ba5b35/output.txt Total script time: 2.45 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/865cbb83ac6b2dd/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7f901872e0b8013/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7f901872e0b8013/output.txt Total script time: 16.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/865cbb83ac6b2dd/output.txt Total script time: 22.85 mins
|
There was a problem hiding this comment.
This seems to work fine, when testing quickly locally.
r=me, with the following question answered:
Did you run a couple of different gulp commands (e.g. generic/firefox/mozcentral/...) locally with/without this patch, just to check that nothing obvious broke with the new package versions?
I'm assuming that you did, but just wanted to double check :-)
Feel free to land this, thank you!
|
Thank you for the review! Yes, the different |
Update all packages to the most recent version
To support this, the following changes have to be made as well:
package-lock.jsonsince NPM creates it, but we should not have it in the repository.babel-preset-es2015tobabel-preset-envto resolve the deprecation warning in the test logs. The latter is more recent and flexible, but should be the same functionality-wise.transformnow needs to have theutf-8encoding option provided. If not given, it will call the callback with aBufferobject, which results in an unhandled promise rejection since what is returned from the callback is a string, not aBuffer.Multiple test log warnings are resolved by this patch.
Fixes #8970