-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace our WeakMap
polyfill with the one from core-js
#9027
Conversation
Since we're already using core-js elsewhere in `compatibility.js`, we can reduce the amount of code we need to maintain ourselves. https://github.com/zloirock/core-js#weakmap
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/15cfa1e8e0c4460/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e7c6fb4e62a85b8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/15cfa1e8e0c4460/output.txt Total script time: 16.85 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e7c6fb4e62a85b8/output.txt Total script time: 23.41 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b0881c48d7b0ed1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b0881c48d7b0ed1/output.txt Total script time: 2.56 mins Published |
Nice work! |
Replace our `WeakMap` polyfill with the one from core-js
Since we're already using core-js elsewhere in
compatibility.js
, we can reduce the amount of code we need to maintain ourselves.https://github.com/zloirock/core-js#weakmap