Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace our WeakMap polyfill with the one from core-js #9027

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Replace our WeakMap polyfill with the one from core-js #9027

merged 1 commit into from
Oct 15, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 15, 2017

Since we're already using core-js elsewhere in compatibility.js, we can reduce the amount of code we need to maintain ourselves.

https://github.com/zloirock/core-js#weakmap

Since we're already using core-js elsewhere in `compatibility.js`, we can reduce the amount of code we need to maintain ourselves.

https://github.com/zloirock/core-js#weakmap
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/15cfa1e8e0c4460/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e7c6fb4e62a85b8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/15cfa1e8e0c4460/output.txt

Total script time: 16.85 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/e7c6fb4e62a85b8/output.txt

Total script time: 23.41 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b0881c48d7b0ed1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/b0881c48d7b0ed1/output.txt

Total script time: 2.56 mins

Published

@timvandermeij timvandermeij merged commit e955168 into mozilla:master Oct 15, 2017
@timvandermeij
Copy link
Contributor

Nice work!

@Snuffleupagus Snuffleupagus deleted the core-js-WeakMap branch October 15, 2017 15:00
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Replace our `WeakMap` polyfill with the one from core-js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants