Disable ftp support in Chrome 59+, add file chooser at file #9595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension cannot easily fetch data from ftp:-resources any more in Chrome 59+. So don't intercept such URLs.
Test case to exercise the different encodings: 1. Create a file "some file#@%M<br>%25 .pdf" 2. Build the extension with `gulp chromium` and load it in Chrome. 3. Go to `chrome://extensions/` and ensure that the "Allow access to file URLs" is disabled. 4. Try to open the file from step 1 in Chrome (maybe reload once). 5. PDF.js should be showing a file chooser button. 6. Click on that button and select a different file. Test: Check that a confirmation dialog pops up that warns about a different file name. Cancel the dialog. 7. Click on the button again and select the original file. Test: Check that the file opens as expected.
Rob--W
changed the title
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Disable ftp support in Chrome 59+, add file chooser at file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9411
Work-around for #8926
Test case for ftp: Visit
ftp://ftp.sagu.edu/and try to open a PDF file that appears there.