Ignore the rest of the image when encountering an EOI (End of Image) marker while parsing Scan data (issue 9679) #9730
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fd381b5a76a73cb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/54d9236ed1a4a92/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/54d9236ed1a4a92/output.txt Total script time: 4.69 mins
Image differences available at: http://54.215.176.217:8877/54d9236ed1a4a92/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fd381b5a76a73cb/output.txt Total script time: 18.98 mins
Image differences available at: http://54.67.70.0:8877/fd381b5a76a73cb/reftest-analyzer.html#web=eq.log |
|
It looks like Webpack is requiring more and more memory lately, and I think this is also what I saw when I tried to upgrade PDF.js to Webpack 4, which worked fine on my machine but not on the bots. There are options to increase allowed memory usage (refer to https://stackoverflow.com/questions/26094420/fatal-error-call-and-retry-last-allocation-failed-process-out-of-memory), but instead of doing that I'd rather find the cause of the excessive memory usage. Indeed it doesn't seem related to this patch at all. |
Since finding/fixing the Webpack issues might take some time/effort, could we simply land this patch as-is given that the Linux bot ran successfully (since its failures are unrelated to image decoding)? |
|
I think that would be OK, but I'm worried that making the reference images may break in the same way. Once I'll have time to review it, I think we can just try and figure out what to do next if that doesn't work. |
|
/botio-windows test |
|
@yurydelendik @brendandahl It looks like the Windows bot is down. Could you restart it? |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/7908b12c01d7fb7/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/7908b12c01d7fb7/output.txt Total script time: 4.88 mins
Image differences available at: http://54.215.176.217:8877/7908b12c01d7fb7/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3e32b56588dfeca/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/3e32b56588dfeca/output.txt Total script time: 4.91 mins
Image differences available at: http://54.215.176.217:8877/3e32b56588dfeca/reftest-analyzer.html#web=eq.log |
|
Slightly off-topic, but given that the Windows bot always seem to fail with |
|
Yes, I think the failures here, the |
Snuffleupagus
force-pushed
the
jpeg-EOI-decodeScan
branch
from
8342078 to
1f52a6e
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bd33c7562c4fefb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/bd33c7562c4fefb/output.txt Total script time: 18.82 mins
Image differences available at: http://54.67.70.0:8877/bd33c7562c4fefb/reftest-analyzer.html#web=eq.log |
…marker while parsing Scan data (issue 9679)
Snuffleupagus
force-pushed
the
jpeg-EOI-decodeScan
branch
from
2443787 to
83ff7d9
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/76a023a7b0d3126/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1737e9e70b27ada/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/76a023a7b0d3126/output.txt Total script time: 18.84 mins
Image differences available at: http://54.67.70.0:8877/76a023a7b0d3126/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/1737e9e70b27ada/output.txt Total script time: 24.94 mins
Image differences available at: http://54.215.176.217:8877/1737e9e70b27ada/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/93746358ab2b7a4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/93746358ab2b7a4/output.txt Total script time: 4.14 mins Published |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/842d0d6e921d563/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/23d545d98d5a7aa/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/842d0d6e921d563/output.txt Total script time: 17.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/23d545d98d5a7aa/output.txt Total script time: 22.72 mins
|
|
Thank you for fixing this (and for the triage of other issues)! Good to have the bots working again too. |
Ignore the rest of the image when encountering an EOI (End of Image) marker while parsing Scan data (issue 9679)
When submitting the "separate image-decoders" PR, I happened to glance briefly at other open JPEG issues and noticed that issue #9679 looked really simple, so...
One caveat here is that I've not run any tests locally, so I suppose that this could fail spectacularly :-)
Edit: The Windows failures looks intermittent (the
formstests), or unrelated to the built-in JPEG decoder. The Linux "failures" are only intexttests, and should thus be unrelated as well; they look like the old "Firefox was updated on the bots, andmakerefis thus needed".