Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #9741

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Build improvements #9741

merged 3 commits into from
Jun 4, 2018

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented May 20, 2018

The objective is to modernize our builds. The first commit updates all packages to their latest versions, except for Webpack. The second commit performs the upgrade to Webpack 4. The third commit includes the package-lock.json file in the repository since this is recommended and it allows for reproducible builds using pinned versions.

Fixes #9688.
Fixes #9000.

@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@timvandermeij timvandermeij changed the title [WIP] Build improvements Build improvements May 20, 2018
@timvandermeij
Copy link
Contributor Author

/botio test

@timvandermeij
Copy link
Contributor Author

/botio-windows test

@timvandermeij
Copy link
Contributor Author

/botio-windows test

@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@timvandermeij
Copy link
Contributor Author

/botio-windows test

@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@timvandermeij
Copy link
Contributor Author

/botio-windows preview

@timvandermeij
Copy link
Contributor Author

timvandermeij commented May 20, 2018

It looks like the out-of-memory errors are not specific to the bots after all, since it also happens in #9737...

V8 appears to have a 1 GB memory limit on 64-bit systems and 512 MB on 32-bit systems. We are hitting that so it seems.

@mozilla mozilla deleted a comment from pdfjsbot May 20, 2018
@timvandermeij
Copy link
Contributor Author

/botio-windows test

@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2018
@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2018
@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2018
@mozilla mozilla deleted a comment from pdfjsbot Jun 2, 2018
@timvandermeij
Copy link
Contributor Author

/botio preview

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/59776c2c4191be6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/b038fa5bd317c68/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/59776c2c4191be6/output.txt

Total script time: 2.91 mins

Published

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/b038fa5bd317c68/output.txt

Total script time: 5.17 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c717c19e0264e8a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/f2403b6fdbbc141/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c717c19e0264e8a/output.txt

Total script time: 1.68 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f2403b6fdbbc141/output.txt

Total script time: 3.17 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/df91c7e5c82ef98/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/03ef4c85e14cc85/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/df91c7e5c82ef98/output.txt

Total script time: 19.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 2, 2018

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/03ef4c85e14cc85/output.txt

Total script time: 23.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/03ef4c85e14cc85/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor Author

Yay! Does anyone have time to review this? I have amended the commits to have the latest versions of every package.

@brendandahl brendandahl merged commit 3c51f2f into mozilla:master Jun 4, 2018
@brendandahl
Copy link
Contributor

Thanks for the updates!

@timvandermeij timvandermeij deleted the webpack branch June 4, 2018 20:45
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@mozilla mozilla deleted a comment May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark as webpack 4 compatible Any reason for not committing the lock file?
4 participants