Remove the jp-JP-mac locale
#9880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gives warnings when running `gulp locale`, in a previous patch it was explicitly asked to remove it and there is quite a bit of discussion about the validity of the locale at https://bugzilla.mozilla.org/show_bug.cgi?id=418485. In short, let's remove it to prevent these issues.
|
Trivial. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Remove the `jp-JP-mac` locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gives warnings when running
gulp locale, in a previous patch it was explicitly asked to remove it and there is quite a bit of discussion about the validity of the locale at https://bugzilla.mozilla.org/show_bug.cgi?id=418485. In short, let's remove it to prevent these issues.Fixes #9878.
Moreover, at https://bugzilla.mozilla.org/show_bug.cgi?id=418485 there is a comment stating that "[...] ja-JP-mac is no longer exposed to web content [...]", so this most likely explains why it was asked to remove it in a previous patch since our language detection would never pick it up anyway.