Change waitOnEventOrTimeout, in web/ui_utils.js, to return a regular Promise and remove the createPromiseCapability import
#9898
Conversation
…r `Promise` and remove the `createPromiseCapability` import *Another small piece of clean-up of code I've previously written; follow-up to PR 8775.* Importing `createPromiseCapability`, and then using it in just *one* spot, seems unnecessary since the `waitOnEventOrTimeout` function may just as well return a regular `Promise` directly.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/10f8f9065c6a533/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e13ab30cc76b7cb/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/10f8f9065c6a533/output.txt Total script time: 6.01 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e13ab30cc76b7cb/output.txt Total script time: 41.65 mins
|
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3ea395bfcb57e89/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3ea395bfcb57e89/output.txt Total script time: 4.28 mins Published |
|
Nice work! |
Snuffleupagus
deleted the
rm-createPromiseCapability-waitOnEventOrTimeout
branch
Another small piece of clean-up of code I've previously written; follow-up to PR 8775.
Importing
createPromiseCapability, and then using it in just one spot, seems unnecessary since thewaitOnEventOrTimeoutfunction may just as well return a regularPromisedirectly.