Ensure that Type0, i.e. composite, OpenType fonts with CFF tables are *not* treated as CFF fonts if their glyph mapping is non-default (issue 9915)
#9938
Conversation
…y decoded This isn't directly related to the subsequent patch, but just something that I happened to notice while poking around in the font code.
…are *not* treated as CFF fonts if their glyph mapping is non-default (issue 9915) This particular code-path has been the source of *numerous* regressions to date, so hopefully this patch won't cause any more of those. Fixes 9915.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/132505bf9aabb2a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7cd8b189c85e331/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7cd8b189c85e331/output.txt Total script time: 19.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/132505bf9aabb2a/output.txt Total script time: 27.30 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1be0957304c9b10/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1be0957304c9b10/output.txt Total script time: 2.85 mins Published |
|
Thank you! |
|
/botio makeref (also for the other PR that landed before without this) |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eb61dc1c3cbcbb0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/02c5672f0ff3250/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/eb61dc1c3cbcbb0/output.txt Total script time: 19.21 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/02c5672f0ff3250/output.txt Total script time: 23.06 mins
|
I attempt to look into this, and it appears that PDFium is basically passing all the font data to FreeType. Unfortunately, I'm getting lost in the FreeType code and cannot really tell where/how it's being handled. |
I've been hanging around, waiting for PDF.js
2.0to be officially released, and fixing a few regressions/smaller issues during that time. This PR is a continuation on that theme.This particular code-path has been the source of numerous regressions to date, so hopefully this patch won't cause any more of those. (All those regressions were, unfortunately, my "fault" as well.)
Fixes #9915.