Removed Extraneous Matrix Check in CalRGB Conversion #9946
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0a9a28a2d0952f5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/aa23da89d6872cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0a9a28a2d0952f5/output.txt Total script time: 19.38 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/aa23da89d6872cd/output.txt Total script time: 27.69 mins
|
brianholle
force-pushed
the
CalRGB_Conversion_Fix
branch
from
153bb2a to
d92e55e
Compare
|
I have updated the commit message as requested.
…On Wed, Aug 1, 2018 at 1:32 PM, Brendan Dahl ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good, one tiny change though. Please update the commit message to
describe your changes or what you're fixing instead of just referencing the
issue number. That makes it easier to read the logs and see what's going on.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9946 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ2mtcS0flyvQyvP4E6Yg7dZPFYGXcOoks5uMhBbgaJpZM4Vq9O1>
.
--
Brian Holle
The University of Scranton - Class of 2017
Computer Information Systems Major & Business Minor
[email protected] | (862) 812-8614
|
timvandermeij
changed the title
|
Unfortunately we just merged two other pull requests and that caused a merge conflict in the |
|
I forgot to mention https://github.com/mozilla/pdf.js/wiki/Squashing-Commits (merge commit case) so that you can rebase without having a merge commit inbetween. The objective is to have only one commit in this PR to keep the history clean. |
brianholle
force-pushed
the
CalRGB_Conversion_Fix
branch
from
cbc80a1 to
2a665eb
Compare
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e8d3a5e3256c921/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a6ae942c8b35519/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e8d3a5e3256c921/output.txt Total script time: 18.30 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a6ae942c8b35519/output.txt Total script time: 23.27 mins
|
This PR contains fixes for issue #9940 . There was an extraneous matrix value check during CalRGB conversion which was not needed. This check was resetting the matrix values to their defaults and distorting the colors of the output file.