Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fallback to system font on font failure. #9958

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

brendandahl
Copy link
Contributor

@brendandahl brendandahl commented Aug 3, 2018

The font in the PDF is marked as a CIDFontType0, but the font file is
actually a true type font. To fully address this issue we should really
peek into the font file and try to determine what it is. However, this
is the first case of this issue, so I think this solution is acceptable for
now.

Fixes #9949

The font in the PDF is marked as a CIDFontType0, but the font file is
actually a true type font. To fully address this issue we should really
peek into the font file and try to determine what it is. However, this
is the first case of this issue, so I think this solution is acceptable for
now.
@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2018

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5424009a1459da3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 3, 2018

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/5ff17b4fa8af9a5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/5ff17b4fa8af9a5/output.txt

Total script time: 28.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/5424009a1459da3/output.txt

Total script time: 36.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f61ff957356eb64/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/f61ff957356eb64/output.txt

Total script time: 7.11 mins

Published

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/999eaaab79c181f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/0d4bb2b2fe810f1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/0d4bb2b2fe810f1/output.txt

Total script time: 23.54 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/999eaaab79c181f/output.txt

Total script time: 33.70 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit 4111871 into mozilla:master Aug 5, 2018
@timvandermeij
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants