Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

The revealed password font is too small #703

Closed
Softvision-CristinaBadescu opened this issue Jan 16, 2018 · 3 comments
Closed

The revealed password font is too small #703

Softvision-CristinaBadescu opened this issue Jan 16, 2018 · 3 comments
Labels
[QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@Softvision-CristinaBadescu
Copy link

Softvision-CristinaBadescu commented Jan 16, 2018

[Affected versions]:

  • Firefox 57.0.4 and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Open the Firefox browser and navigate to https://send.dev.mozaws.net/.
  2. Upload a file and select the "Require a password" checkbox.
  3. Type something in the password field and click "Add password" button.
  4. Hover over the masked password and observe its font.

[Expected result]:

  • The revealed password font is big enough to be visible from a normal distance.

[Actual result]:

  • The revealed password font is too small.

[Notes]:

  • The password seems to be bold on Mac 10.12.6 and Linux 4.12, but not on Windows 10 x64.
  • Here is a screen recording of the issue:
    wrong font displayed for password
@shikhar-scs
Copy link
Contributor

shikhar-scs commented Jan 16, 2018

@Softvision-CristinaBadescu This functionality of masking the password was added by me in #686 .
I had ensured that the font remains the same (you can have a look at the gif files attached there).

However, later here the font-family was chaged to monospace by dannycoates( the main member ) himself. So, I guess this should not be an issue.

@dannycoates
Copy link
Contributor

I did change the password font on purpose so that the masked password and revealed password take up the same amount of space. It does look a bit to small now so I can bump up the size, but I think it should remain monospaced.

@Softvision-CristinaBadescu Softvision-CristinaBadescu changed the title Wrong font is displayed for the set password The revealed password font is too small Jan 17, 2018
@Softvision-CristinaBadescu
Copy link
Author

@shikhar-scs, @dannycoates I'm sorry, somehow I've missed that.

I agree with Danny that we should make the revealed password font bigger so it will be more visible. Considering this, I'm going to edit this issue so that it suits our situation.

@dannycoates dannycoates added this to the Ornery Octopus 🐙 milestone Jan 20, 2018
@SoftVision-CosminMuntean SoftVision-CosminMuntean added [QA]:Verified fixed Label for QA to mark verified fixed issues [QA]:Minor issue Label for QA to mark minor issues logged labels May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

4 participants