commit subgroup check benches from https://github.com/mratsim/constan…

…tine/pull/368\#issuecomment-2047473465
mratsim · Apr 27, 2024 · d1af981 · d1af981
1 parent 2a805d8
commit d1af981
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 0 deletions.
diff --git a/benchmarks/bench_summary_bls12_377.nim b/benchmarks/bench_summary_bls12_377.nim
@@ -76,6 +76,9 @@ proc main() =
     finalExpBLS12Bench(curve, Iters)
     pairingBLS12Bench(curve, Iters)
     separator()
+    subgroupCheckBench(ECP_ShortW_Jac[Fp[curve], G1], Iters)
+    subgroupCheckBench(ECP_ShortW_Jac[Fp2[curve], G2], Iters)
+    separator()
 
 main()
 notes()
diff --git a/benchmarks/bench_summary_bls12_381.nim b/benchmarks/bench_summary_bls12_381.nim
@@ -80,6 +80,9 @@ proc main() =
     hashToCurveBLS12381G1Bench(Iters)
     hashToCurveBLS12381G2Bench(Iters)
     separator()
+    subgroupCheckBench(ECP_ShortW_Jac[Fp[curve], G1], Iters)
+    subgroupCheckBench(ECP_ShortW_Jac[Fp2[curve], G2], Iters)
+    separator()
 
 main()
 notes()
diff --git a/benchmarks/bench_summary_bn254_nogami.nim b/benchmarks/bench_summary_bn254_nogami.nim
@@ -76,6 +76,9 @@ proc main() =
     finalExpBNBench(curve, Iters)
     pairingBNBench(curve, Iters)
     separator()
+    subgroupCheckBench(ECP_ShortW_Jac[Fp[curve], G1], Iters)
+    subgroupCheckBench(ECP_ShortW_Jac[Fp2[curve], G2], Iters)
+    separator()
 
 main()
 notes()
diff --git a/benchmarks/bench_summary_bn254_snarks.nim b/benchmarks/bench_summary_bn254_snarks.nim
@@ -79,6 +79,9 @@ proc main() =
     hashToCurveBN254SnarksG1Bench(Iters)
     hashToCurveBN254SnarksG2Bench(Iters)
     separator()
+    subgroupCheckBench(ECP_ShortW_Jac[Fp[curve], G1], Iters)
+    subgroupCheckBench(ECP_ShortW_Jac[Fp2[curve], G2], Iters)
+    separator()
 
 main()
 notes()
diff --git a/benchmarks/bench_summary_template.nim b/benchmarks/bench_summary_template.nim
@@ -290,3 +290,10 @@ proc hashToCurveBN254SnarksG2Bench*(iters: int) =
       message = msg,
       domainSepTag = dst
     )
+
+proc subgroupCheckBench*(EC: typedesc, iters: int) =
+  var P = rng.random_unsafe(EC)
+  P.clearCofactor()
+
+  bench("Subgroup check", EC, iters):
+    discard P.isInSubgroup()