adding possibility to add SMTP configuration #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
suggested changes
Jun 13, 2019
…rver test data indentation + extra smtpServer update test
|
All request changes were added + I have updated the branch to latest version of master |
mrparkers
approved these changes
Jun 14, 2019
|
@tomrutsaert I just noticed this after merging, but what would you think of handling SMTP auth like this instead? resource "keycloak_realm" "test" {
realm = "test"
smtp_server {
host = "mysmtphost.com"
from = "[email protected]"
auth {
user = "tom"
password = "tom"
}
}
}If you're okay with this, I'll push up a quick fix and cut a release for you within the next few days. |
|
Seems like a good idea, go ahead |
tomrutsaert
added a commit
to tomrutsaert/terraform-provider-keycloak
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding possibility to add SMTP Server configuration.