Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix required group_id in resource keycloak_group_roles #292

Merged
merged 1 commit into from
May 20, 2020
Merged

fix required group_id in resource keycloak_group_roles #292

merged 1 commit into from
May 20, 2020

Conversation

elmarx
Copy link
Contributor

@elmarx elmarx commented May 18, 2020

Hey,

Just noticed the argument group_id is errorneously marked as "optional", although… this could never work without a group_id, there's an error when executing terraform, and the doc says group_id is required.

mrparkers
mrparkers approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, thanks for the fix!

@mrparkers mrparkers merged commit 7b773c9 into keycloak:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elmarx @mrparkers