-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add groups path to LDAP group mapper #436
Conversation
af16c39
to
e52b29e
Compare
8e6beb7
to
61532b4
Compare
Hi, @mrparkers sorry to ask you this but I think I don't quite understand how tests are supposed to validate the terraform state. I cannot see what needs to be modified in order to include the Cheers! |
1d39fd0
to
04e994f
Compare
👋 @mrparkers your guidance would be appreciated. Please let me know what I need to change when you have a bit of spare time. Thanks again for your time maintaining this provider. Cheers, |
Hey @AdrienFromToulouse, sorry for the really late review here. I took a look at this, and the tests for version 9 and 10 appear to be failing because the ability to set the group path for LDAP group mappers was added in version 11. So I opened #444 to add some functionality to the Keycloak client so that we can check the version we're using during plan / apply time, which will allow us to decide to optionally not set this attribute when using an older version. Once I merge #444, I can take a look at why the tests are failing for version 11. |
04e994f
to
7945450
Compare
I went ahead and made a change to mark this attribute as computed instead of specifying a default. This seemed to fix the test failures we were running into. I also didn't realize that this attribute expects a group with that path to already exist, so I added a test for this. Let me know what you think and we can get this merged. |
👋 you are awesome @mrparkers I did not pay attention to the fact that the group had to be pre-existing... my bad. Many thanks for your help on this 🚀 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, thanks for the PR!
Closes #435