Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add groups path to LDAP group mapper #436

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

AdrienFromToulouse
Copy link
Contributor

@AdrienFromToulouse AdrienFromToulouse commented Nov 9, 2020

Closes #435

@AdrienFromToulouse AdrienFromToulouse changed the title feat: add group path to LDAP group mapper feat: add groups path to LDAP group mapper Nov 9, 2020
@AdrienFromToulouse AdrienFromToulouse changed the title feat: add groups path to LDAP group mapper WIP: feat: add groups path to LDAP group mapper Nov 9, 2020
@AdrienFromToulouse AdrienFromToulouse force-pushed the feature/#435 branch 6 times, most recently from 8e6beb7 to 61532b4 Compare November 9, 2020 14:50
@AdrienFromToulouse
Copy link
Contributor Author

Hi, @mrparkers sorry to ask you this but I think I don't quite understand how tests are supposed to validate the terraform state. I cannot see what needs to be modified in order to include the groups_path property.
If you have some hints to give me I would be happy to proceed.

Cheers!

@AdrienFromToulouse AdrienFromToulouse force-pushed the feature/#435 branch 3 times, most recently from 1d39fd0 to 04e994f Compare November 10, 2020 07:36
@AdrienFromToulouse
Copy link
Contributor Author

👋 @mrparkers your guidance would be appreciated. Please let me know what I need to change when you have a bit of spare time.

Thanks again for your time maintaining this provider.

Cheers,

@mrparkers
Copy link
Contributor

Hey @AdrienFromToulouse, sorry for the really late review here.

I took a look at this, and the tests for version 9 and 10 appear to be failing because the ability to set the group path for LDAP group mappers was added in version 11. So I opened #444 to add some functionality to the Keycloak client so that we can check the version we're using during plan / apply time, which will allow us to decide to optionally not set this attribute when using an older version.

Once I merge #444, I can take a look at why the tests are failing for version 11.

@mrparkers
Copy link
Contributor

I went ahead and made a change to mark this attribute as computed instead of specifying a default. This seemed to fix the test failures we were running into. I also didn't realize that this attribute expects a group with that path to already exist, so I added a test for this.

Let me know what you think and we can get this merged.

@AdrienFromToulouse
Copy link
Contributor Author

👋 you are awesome @mrparkers I did not pay attention to the fact that the group had to be pre-existing... my bad.

Many thanks for your help on this 🚀 👍

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, thanks for the PR!

@mrparkers mrparkers changed the title WIP: feat: add groups path to LDAP group mapper feat: add groups path to LDAP group mapper Dec 10, 2020
@mrparkers mrparkers merged commit 15ab38b into keycloak:master Dec 10, 2020
@AdrienFromToulouse AdrienFromToulouse deleted the feature/#435 branch December 14, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ldap] - missing groups path in group-ldap-mapper
2 participants