Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support use-refresh-tokens for client credentials in openid_client #678

Conversation

daviddelannoy
Copy link
Contributor

Hi @mrparkers

I needed support of keycloak flag client_credentials.use_refresh_token on keycloak_openid_client so I have added support in this MR (almost same as use_refresh_tokens)

Thanks for the review

@daviddelannoy
Copy link
Contributor Author

Hi,

Test pipeline have failed but I think that it is not related to this PR (same error in previous PRs), I'm not allowed to launch it again, could you do that @mrparkers ? Thanks 🙂

@daviddelannoy daviddelannoy force-pushed the feature/use-refresh-tokens-client-credentials branch from 4ff1411 to c456084 Compare April 29, 2022 12:39
@daviddelannoy
Copy link
Contributor Author

Hi @mrparkers

Any chance to merge this PR soon ?
Thanks !

Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry this took so long to review. But this looks great, thanks for submitting this PR!

@mrparkers mrparkers merged commit 7d9a762 into keycloak:master May 3, 2022
@daviddelannoy
Copy link
Contributor Author

Thanks a lot @mrparkers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants