fix: avoid inserting authenticator execution config with empty string as id #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
force-pushed
the
keycloak-21-1-execution-config
branch
from
5a705a6 to
92d84e3
Compare
mrparkers
approved these changes
May 31, 2023
|
Any chance we can get a release with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #839. To verify, I just did a targeted deploy of the example execution config resource on my local instance of Keycloak 21.1.1.
Maybe we should consider add the
omitemptydecorator to the other Id types since these will probably avoid similar errors for other resources that Keycloak supports importing with IDs?