Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete request does not include name in the path #41

Closed
jonatanklosko opened this issue Oct 24, 2024 · 5 comments · Fixed by #42
Closed

Delete request does not include name in the path #41

jonatanklosko opened this issue Oct 24, 2024 · 5 comments · Fixed by #42

Comments

@jonatanklosko
Copy link
Contributor

I've just noticed that removing a PVC actually removes all PVC in the same namespace. I think the reason is that the URL doesn't include name, so it's a batch delete:

[url: String.replace_suffix(request_path, "/:name", ""), method: :delete]

@mruoss
Copy link
Owner

mruoss commented Oct 24, 2024

Oof... big ooooops! I recall notice and fixing this... but... this stripping should actually be on the :delete_all funciton. I'll fix asap.

@mruoss
Copy link
Owner

mruoss commented Oct 24, 2024

Just remembered. Fixed on a branch I didn't think would take so long to finish...
https://github.com/mruoss/kubereq/pull/37/files#diff-d5076506e5cc95b8453c90eb47671444dce56e8ed79ce5503e22b9a6e47c87ca

I will fix and release asap.

@jonatanklosko
Copy link
Contributor Author

Thank you!

@mruoss
Copy link
Owner

mruoss commented Oct 24, 2024

@jonatanklosko Shall I provide a PR for updating livebook or are you going to do it?

@jonatanklosko
Copy link
Contributor Author

@mruoss already updated, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants