rust: fix clangarm64 build #14777
Merged
rust: fix clangarm64 build #14777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b2a6d1.
This reverts commit 7a4aa66.
This reverts commit a437528.
The bash array _rust_conf was being used as a 'scalar' (for lack of a better term), resulting in only the first item being interpolated, losing the `--enable-vendor` option necessary for a -gnullvm target to build due to necessary patches to the vendored sources. Currently, only clangarm64 uses a gnullvm target, so it was the only one affected. Addresses msys2#14592 (comment)
|
(I missed the review request, oops) |
|
Just did that to make sure he saw it, not important. |
|
Sorry, I've only got home this morning 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bash array _rust_conf was being used as a 'scalar' (for lack of a
better term), resulting in only the first item being interpolated,
losing the
--enable-vendoroption necessary for a -gnullvm target tobuild due to necessary patches to the vendored sources. Currently, only
clangarm64 uses a gnullvm target, so it was the only one affected.
Addresses #14592 (comment)