[Tabs] Support vertical tabs #16628
Merged
[Tabs] Support vertical tabs #16628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpung
changed the title
oliviertassinari
added
component: tabs
oliviertassinari
force-pushed
the
vertical-tabs-demo
branch
3 times, most recently
from
d0ae7f0 to
c378d2c
Compare
|
@josephpung Thanks for starting this effort! I have pushed the effort one step further:
<Tabs orientation="vertical" variant="scrollable" /> |
|
@material-ui/core: parsed: +0.20% , gzip: +0.29% Details of bundle changes.Comparing: 20b3ab9...2e7e487
|
oliviertassinari
force-pushed
the
vertical-tabs-demo
branch
2 times, most recently
from
53a5954 to
5be2b8d
Compare
oliviertassinari
changed the title
|
@josephpung Could you have a look at my changes? Thanks! |
|
@oliviertassinari this is much better! I was having trouble trying to modify the tabIndicator, its cleaner as well without the need to pass the orientation props to the Tab component 👍 |
|
Ok cool. I will keep it open longer so we can collect more feedback. |
eps1lon
reviewed
Jul 22, 2019
| ScrollButtonComponent?: React.ElementType; | ||
| scrollButtons?: 'auto' | 'desktop' | 'on' | 'off'; | ||
| TabIndicatorProps?: Partial<TabIndicatorProps>; | ||
| TabIndicatorProps?: Partial<React.HTMLAttributes<HTMLDivElement>>; |
There was a problem hiding this comment.
Not disagreeing with this change but we should update the documentation as well:
Properties applied to the TabIndicator element.
Since this isn't a documented component we shouldn't use a proper noun here.
|
@eps1lon Thanks for the review. I will fix the two reported issues. |
oliviertassinari
force-pushed
the
vertical-tabs-demo
branch
from
5be2b8d to
41709a7
Compare
2 tasks
|
Very nice work. Looks really slick! |
|
@josephpung Thanks for starting this effort. I'm very happy to see this +20 upvotes issue addressed. |
Happy to be able to help in any way I can! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8662
Closes #16697
I've been working with the sidebar alternative for a while, while at the same time keeping track of the progress of vertical tabs (im aware it a proper version is probably coming more towards v5). This is something I have been working on as a solution, not sure if it would be viable as an official change but i have applied the modifications to the Simple Tabs demo.
Edit @eps1lon:
material-ui.com: vertical tabs