Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo in typography.md #16654

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

hexium310
Copy link
Contributor

Fix typo in typography.md and some typography-*.md.
occassion -> occasion

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. You don't need to fix the translated versions though. They are handled by crowdin. Please only include changes to typography.md

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Jul 19, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 19, 2019

No bundle size changes comparing b3218e7...bc64ad4

Generated by 🚫 dangerJS against bc64ad4

@@ -59,7 +59,7 @@ Hopefully, you might be able to take advantage of the [`typography`](/customizat
The Typography component uses the `variantMapping` property to associate a UI variant with a semantic element.
It’s important to realize that the style of a typography is independent from the semantic underlying element.

- You can change the underlying element for a one time occassion with the `component` property:
- You can change the underlying element for a one time occasion with the `component` property:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are going to invalidate the crowding translation, we might have well fix this:

Suggested change
- You can change the underlying element for a one time occasion with the `component` property:
- You can change the underlying element for a one time occasion with the `component` prop:

@hexium310 hexium310 force-pushed the fix-typo-typography-docs branch from 4db60fd to bc64ad4 Compare July 19, 2019 20:12
@oliviertassinari oliviertassinari merged commit e5bb532 into mui:master Jul 19, 2019
@oliviertassinari
Copy link
Member

@hexium310 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants