[ci] Use custom frozen lockfile check #16677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 1b9d5cb...57b835b |
eps1lon
force-pushed
the
ci/no-frozen-lockfile
branch
from
ddfc6b0 to
6812981
Compare
joshwooding
approved these changes
Jul 22, 2019
workspace packages are automatically linked
eps1lon
force-pushed
the
ci/no-frozen-lockfile
branch
from
73cc33d to
57b835b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frozen lockfile was used to prevent yarn from regenerating some git dependency of
dtslint. By only running it in CI we risked integrating lockfiles that change on the initial install (bad 1st contribute experience) so we added it by default.However the working with the flag enabled is a bit cumbersome. Since we already have a check in CI against integrating outdated lockfiles (git diff after yarn) we don't need it anyway.
Since none of the active core contributers had a problem with running yarn without frozen-lockfile we can remove it. Need to properly debug the issue the next time it gets reported instead of blindly accepting fixes. It's important to boost productivity for the people that work the most on the workspace.