[workspace] Bump babel dependencies to latest #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jul 23, 2019
| @@ -133,6 +133,12 @@ | |||
| "yarn-deduplicate": "^1.1.1" | |||
| }, | |||
| "resolutions": { | |||
| "**/@babel/core": "^7.5.4", | |||
There was a problem hiding this comment.
These are dependencies of the workspace and nextjs.
Details of bundle changes.Comparing: d0e6458...7be9ea9
|
eps1lon
commented
Jul 23, 2019
| @@ -37,7 +37,7 @@ | |||
| "react-dom": "^16.8.0" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.2.0", | |||
| "@babel/runtime": "^7.4.4", | |||
There was a problem hiding this comment.
If we transpile with @babel/plugin-transform-runtime then we need a production dependency that is equal or higher to the transform version. Otherwise missing dependencies can occur downstream. Consider the following scenario:
Downstream:
@material-ui/core: 4.0.0
@babel/runtime: 7.2.0
Upstream:
@babel/plugin-transform-runtime: 7.2.0
Now we bump @babel/plugin-transform-runtime by a minor. In that minor a @babel/plugin-transform-runtime leverages a new helper method that is introduced in 7.3.0. We release a new version of @material-ui/core which is built with @babel/[email protected] without bumping th @babel/runtime dependency entry. Downstream updates @material-ui/core but not @babel/runtime since the semver range still matches. The downloaded package of @material-ui/core has no access to the new helper function and crashes.
I think we got reports of this a couple of times. It's fixable downstream by bumping @babel/runtime but wouldn't need intervention if we would also bump the entry of @babel/runtime.
|
If I understand that changes correctly, we undo the tradeoff Next.js took regarding Babel. We will use a more recent version of Babel than Next.js uses. So we win access to the latest Babel enhancements, x months in advance. |
|
It's more about making sure we have a proper node_modules layout. We were using nextjs babel packages for months before we upgraded to The stance "can't introduce breakage if you don't upgrade" is motivated by the assumption that your current code is bug free which is just hybris. It's not about undoing a "tradeoff" but fixing a rational that is incomplete. Again it's less about features but making sure we have the latest fixes. |
oliviertassinari
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump babel dependencies and force a single version.
Those don't really work as nested node_modules anyway since the babel.config lives at the root.