[ci] Merge test_browser and test_production #16731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 942e56a...f4476e0 |
|
Done, looks well balanced :)
|
oliviertassinari
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was originally introduced with the assumption we have at least 5 parallel jobs. Since we only have 4 we will already starve CI with a single build.
Microjobs are not worth it since every job has a fixed duration of around 1 minute (restore/save cache, install deps). Only ~30% of the time of
test_productionwas actually spent in the test.Merging it with
test_browsermakes sense because it requires the same dependencies.@oliviertassinari could you remove
test_productionfrom the required GitHub checks please?