Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Workaround to describe aria-sort #16767

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jul 26, 2019

A workaround for #16760

Closes #16760

@mui-pr-bot
Copy link

No bundle size changes comparing cfedbcb...88b95fd

Generated by 🚫 dangerJS against 88b95fd

@@ -233,6 +239,17 @@ const useStyles = makeStyles((theme: Theme) =>
tableWrapper: {
overflowX: 'auto',
},
visuallyHidden: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a different topic, I was wondering about providing a similar feature: https://getbootstrap.com/docs/4.3/utilities/screen-readers/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered the same thing. (Although Bootstrap's example of using it for a skip-nav is misguided.)

@eps1lon eps1lon added accessibility a11y docs Improvements or additions to the documentation labels Jul 27, 2019
@joshwooding joshwooding merged commit 425419c into mui:master Jul 27, 2019
@mbrookes mbrookes deleted the table-demo-sort-description branch July 27, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChromeVox on Google Chrome doesn't announce ascending/descending sorting on <TableSortLabel> button
5 participants