[docs] Grammar fix for global class names docs #16778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 3f9fa1f...d88bc8e |
merceyz
reviewed
Jul 28, 2019
|
|
||
| - With a rule name of the [\`classes\` object prop](/customization/components/#overriding-styles-with-classes). | ||
| - With a [global class name](/customization/components/#overriding-styles-with-global-class-names). | ||
| - With a theme and an [\`overrides\` property](/customization/globals/#css). | ||
|
|
||
| If it's not enough, you can find the [implementation of the component](${SOURCE_CODE_ROOT_URL}${normalizePath( | ||
| If that's not sufficient, you can check the [implementation of the component](${SOURCE_CODE_ROOT_URL}${normalizePath( | ||
| reactAPI.filename, | ||
| )}) for more detail. |
There was a problem hiding this comment.
Suggested change
| )}) for more detail. | |
| )}) for more details. |
There was a problem hiding this comment.
It seems to depend on the context. Do we want to focus on the quality or the quantity of extra information: https://english.stackexchange.com/questions/123672/detail-or-details-read-on-for-more-detail-details?
There was a problem hiding this comment.
Note, we were using "detail" in the past, highlighting the quality aspect. We are also using "detail" when the ref is attached to an imperative handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #16770 (review)
cc @mbrookes