[docs] Add Typescript example for switch label position #16959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing f2dbeca...6b9c8e5 |
oliviertassinari
changed the title
oliviertassinari
added
component: switch
oliviertassinari
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr; -> I added Typescript example for Switch label position.
Hi!
I wanted to add Typescript example for label position with Switch component. However once I took a look at code it quickly turned out that there aren't necessarily any typings needed.
The reason for that was that the logic inside the component went a little bit further than just the label placement. That's why I decided to simplify it a little bit so that this demo only shows different ways of label placement and not the state management possibilities of
<FormGroup>component.I'm not sure if you find this helpful. If you'd like I could just revert my refactoring and simply add the typing for event handler.