Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Add support for a Dialog without a DialogTitle #16980

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

megos
Copy link
Contributor

@megos megos commented Aug 13, 2019

Spacing is narrow when use dialog without title.

https://material.io/design/components/dialogs.html

before after
before after

Has no effect when with title.

with-title

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Aug 13, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good. I have given it a second look to iron some other details.

@oliviertassinari oliviertassinari added the new feature New feature or request label Aug 13, 2019
@oliviertassinari oliviertassinari force-pushed the fix-style-dialog-wo-title branch from 82f8a9a to 5013002 Compare August 13, 2019 13:40
@oliviertassinari oliviertassinari changed the title [DialogContent] Fix dialog content padding without title [Dialog] Add support for no DialogTitle Aug 13, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 67f4657...5013002

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.02% 🔺 +0.01% 🔺 328,822 328,874 89,898 89,904
@material-ui/core/Paper 0.00% 0.00% 68,684 68,684 20,476 20,476
@material-ui/core/Paper.esm 0.00% 0.00% 62,058 62,058 19,206 19,206
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab 0.00% 0.00% 152,975 152,975 46,649 46,649
@material-ui/styles 0.00% 0.00% 51,401 51,401 15,290 15,290
@material-ui/system 0.00% 0.00% 15,658 15,658 4,361 4,361
Button 0.00% 0.00% 78,687 78,687 24,044 24,044
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,047 70,047 21,881 21,881
Slider 0.00% 0.00% 74,338 74,338 23,043 23,043
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,846 51,846 13,780 13,780
docs.main 0.00% 0.00% 590,557 590,557 188,449 188,449
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 +0.01% 🔺 299,821 299,873 86,253 86,260

Generated by 🚫 dangerJS against 5013002

@joshwooding joshwooding changed the title [Dialog] Add support for no DialogTitle [Dialog] Add support for a Dialog without a DialogTitle Aug 13, 2019
@joshwooding joshwooding merged commit 03e2190 into mui:master Aug 13, 2019
@joshwooding
Copy link
Member

@megos It's a great first contribution to Material-UI. 🎉It's always great to see us getting closer to the spec. Thanks for working on it :)

aloiret pushed a commit to aloiret/material-ui that referenced this pull request Aug 15, 2019
* Fix dialog content padding without title

* even closer to spec
aloiret pushed a commit to aloiret/material-ui that referenced this pull request Aug 16, 2019
* Fix dialog content padding without title

* even closer to spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants