Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix mouse enter edge case for Firefox #16986

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

Astrantia
Copy link
Contributor

@Astrantia Astrantia commented Aug 13, 2019

As suggested by @oliviertassinari in #16983 (comment)

Closes #16983

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 67f4657...807fb7d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.01% 🔺 328,822 328,846 89,898 89,908
@material-ui/core/Paper 0.00% 0.00% 68,684 68,684 20,476 20,476
@material-ui/core/Paper.esm 0.00% 0.00% 62,058 62,058 19,206 19,206
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab +0.02% 🔺 +0.02% 🔺 152,975 152,999 46,649 46,659
@material-ui/styles 0.00% 0.00% 51,401 51,401 15,290 15,290
@material-ui/system 0.00% 0.00% 15,658 15,658 4,361 4,361
Button 0.00% 0.00% 78,687 78,687 24,044 24,044
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,047 70,047 21,881 21,881
Slider +0.03% 🔺 +0.06% 🔺 74,338 74,362 23,043 23,056
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,846 51,846 13,780 13,780
docs.main 0.00% 0.00% 590,557 590,557 188,449 188,449
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.01% 🔺 299,821 299,845 86,253 86,263

Generated by 🚫 dangerJS against 807fb7d

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels Aug 13, 2019
@oliviertassinari oliviertassinari changed the title Fix Slider.js for Firefox [Slider] Fix mouse enter edge case for Firefox Aug 13, 2019
@joshwooding joshwooding merged commit f4df375 into mui:master Aug 13, 2019
@joshwooding
Copy link
Member

It's a great first contribution to Material-UI. 🎉 Thanks for working on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider not working correctly on Firefox
4 participants