Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Hide SVG icon for native multiple select #16992

Merged
merged 2 commits into from
Aug 14, 2019
Merged

[Select] Hide SVG icon for native multiple select #16992

merged 2 commits into from
Aug 14, 2019

Conversation

craigmjackson
Copy link
Contributor

@craigmjackson craigmjackson commented Aug 14, 2019 •
edited by oliviertassinari
Loading

Closes #16967

SVG icon is on top of the native multiple select scrollbar without this fix

@craigmjackson craigmjackson mentioned this pull request Aug 14, 2019
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 14, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 7d01949...96138be

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 328,898 328,914 89,914 89,918
@material-ui/core/Paper 0.00% 0.00% 68,684 68,684 20,476 20,476
@material-ui/core/Paper.esm 0.00% 0.00% 62,058 62,058 19,206 19,206
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab 0.00% 0.00% 152,999 152,999 46,659 46,659
@material-ui/styles 0.00% 0.00% 51,401 51,401 15,290 15,290
@material-ui/system 0.00% 0.00% 15,658 15,658 4,361 4,361
Button 0.00% 0.00% 78,687 78,687 24,044 24,044
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,047 70,047 21,881 21,881
Slider 0.00% 0.00% 74,362 74,362 23,056 23,056
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 51,846 51,846 13,780 13,780
docs.main 0.00% 0.00% 590,557 590,557 188,449 188,449
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.01% 🔺 299,897 299,913 86,270 86,279

Generated by 🚫 dangerJS against 96138be

@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Aug 14, 2019
@oliviertassinari oliviertassinari changed the title [Select] Ensured SVG icon is not displayed for native multiple Select… [Select] Hide SVG icon native multiple select Aug 14, 2019
@oliviertassinari oliviertassinari changed the title [Select] Hide SVG icon native multiple select [Select] Hide SVG icon for native multiple select Aug 14, 2019
@oliviertassinari oliviertassinari merged commit 8c94e2a into mui:master Aug 14, 2019
aloiret pushed a commit to aloiret/material-ui that referenced this pull request Aug 15, 2019
@craigmjackson @aloiret-ed
[Select] Hide SVG icon for native multiple select (mui#16992)
5273a6e 
* [Select] Ensured SVG icon is not displayed for native multiple Select components

* simple test
aloiret pushed a commit to aloiret/material-ui that referenced this pull request Aug 16, 2019
@craigmjackson @aloiret-ed
[Select] Hide SVG icon for native multiple select (mui#16992)
8f8623e 
* [Select] Ensured SVG icon is not displayed for native multiple Select components

* simple test
This was referenced Sep 4, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select component still renders material SVG icon even with native prop set
3 participants
@craigmjackson @mui-pr-bot @oliviertassinari