Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] Better support custom theme spacing values #17005

Merged
merged 4 commits into from
Aug 20, 2019
Merged

[Grid] Better support custom theme spacing values #17005

merged 4 commits into from
Aug 20, 2019

Conversation

Workvictor
Copy link
Contributor

@Workvictor Workvictor commented Aug 14, 2019 •
edited by oliviertassinari
Loading

Closes #11910

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 14, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 10ed7cf...b28fe3e

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.06% 🔺 +0.06% 🔺 329,178 329,360 90,019 90,071
@material-ui/core/Paper 0.00% 0.00% 68,843 68,843 20,523 20,523
@material-ui/core/Paper.esm 0.00% 0.00% 62,217 62,217 19,249 19,249
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,135 2,135
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab 0.00% 0.00% 153,211 153,211 46,742 46,742
@material-ui/styles 0.00% 0.00% 51,561 51,561 15,339 15,339
@material-ui/system 0.00% 0.00% 15,658 15,658 4,360 4,360
Button 0.00% 0.00% 78,847 78,847 24,093 24,093
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,206 70,206 21,925 21,925
Slider 0.00% 0.00% 74,539 74,539 23,108 23,108
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing +0.37% 🔺 +0.55% 🔺 53,311 53,507 13,786 13,862
docs.main 0.00% 0.00% 599,123 599,123 191,150 191,150
packages/material-ui/build/umd/material-ui.production.min.js +0.06% 🔺 +0.06% 🔺 300,169 300,351 86,407 86,455

Generated by 🚫 dangerJS against b28fe3e

@Workvictor Workvictor mentioned this pull request Aug 14, 2019
Closed
2 tasks
@Workvictor
Copy link
Contributor Author

Should I return the standard demo component (without ThemeProvider)?

@oliviertassinari oliviertassinari added the component: Grid The React component. label Aug 14, 2019
@oliviertassinari oliviertassinari changed the title [Grid] Fix spacing calculation for Grid component when theme spacing function returns string value [Grid] Better support custom theme spacing values Aug 15, 2019
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Aug 15, 2019
@oliviertassinari
Copy link
Member

Looks good.

@oliviertassinari oliviertassinari merged commit e66fb61 into mui:master Aug 20, 2019
@oliviertassinari
Copy link
Member

@Workvictor It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

This was referenced Sep 4, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Grid The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Grid] Replace px to rem in spacing prop
3 participants
@Workvictor @mui-pr-bot @oliviertassinari