Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Hide mark labels to screen readers #17024

Merged
merged 3 commits into from
Aug 17, 2019
Merged

[Slider] Hide mark labels to screen readers #17024

merged 3 commits into from
Aug 17, 2019

Conversation

Patil2099
Copy link
Contributor

Fixes #16921

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 16, 2019

Details of bundle changes.

Comparing: 3d973a2...dba5476

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 -0.00% 329,139 329,156 90,010 90,008
@material-ui/core/Paper 0.00% 0.00% 68,843 68,843 20,523 20,523
@material-ui/core/Paper.esm 0.00% 0.00% 62,217 62,217 19,249 19,249
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,135 2,135
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,826 5,826
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,059 1,059
@material-ui/lab +0.01% 🔺 +0.01% 🔺 153,172 153,189 46,726 46,732
@material-ui/styles 0.00% 0.00% 51,561 51,561 15,339 15,339
@material-ui/system 0.00% 0.00% 15,658 15,658 4,360 4,360
Button 0.00% 0.00% 78,847 78,847 24,093 24,093
Modal 0.00% 0.00% 14,346 14,346 5,011 5,011
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,206 70,206 21,925 21,925
Slider +0.02% 🔺 +0.03% 🔺 74,522 74,539 23,100 23,108
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 53,311 53,311 13,786 13,786
docs.main 0.00% 0.00% 599,106 599,106 191,143 191,143
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.01% 🔺 300,130 300,147 86,386 86,394

Generated by 🚫 dangerJS against dba5476

@oliviertassinari oliviertassinari changed the title Update Slider.js [Slider] Hide mark labels to screen readers Aug 16, 2019
@oliviertassinari oliviertassinari added accessibility a11y component: slider This is the name of the generic UI component, not the React module! labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marks for sliders end up as unassociated text in screen readers
4 participants