Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CardHeader] Remove mention of children from API docs #17045

Merged
merged 2 commits into from
Aug 20, 2019
Merged

[CardHeader] Remove mention of children from API docs #17045

merged 2 commits into from
Aug 20, 2019

Conversation

cmeeren
Copy link
Contributor

@cmeeren cmeeren commented Aug 18, 2019

See #17036.

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 18, 2019 •
edited
Loading

No bundle size changes comparing e5b4aa0...fe84db2

Generated by 🚫 dangerJS against fe84db2

@cmeeren cmeeren changed the title Remove mention of children from CardHeader API [CardHeader] Remove mention of children from API docs Aug 18, 2019
@mbrookes
Copy link
Member

@cmeeren Thanks for giving it a go. What do you think about keeping the second part as is, as it is the text that would be wrapped.

To fix the error, you need to edit the comment in the CardHeader source, and run yarn docs:api to generate the markdown.

@mbrookes mbrookes added component: card This is the name of the generic UI component, not the React module! component: CardHeader docs Improvements or additions to the documentation and removed component: card This is the name of the generic UI component, not the React module! labels Aug 18, 2019
joshwooding
joshwooding previously requested changes Aug 18, 2019
View reviewed changes
Copy link
Member

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Matt the second part seems fine as is.

@mbrookes mbrookes merged commit 490ca9b into mui:master Aug 20, 2019
@cmeeren cmeeren deleted the patch-1 branch August 20, 2019 17:45
This was referenced Sep 4, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmeeren @mui-pr-bot @mbrookes @oliviertassinari @joshwooding