From e8f2a341dfeb2bd503333f0988edcd65fcd53022 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 30 Jun 2024 17:07:54 +0530 Subject: [PATCH 1/2] Bump @definitelytyped tools (#42789) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- package.json | 6 +++--- pnpm-lock.yaml | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index bd33c950dbd69d..0f3086ae73cea9 100644 --- a/package.json +++ b/package.json @@ -202,9 +202,9 @@ "@babel/preset-typescript": "^7.24.7", "@babel/runtime": "^7.24.7", "@babel/types": "^7.24.7", - "@definitelytyped/header-parser": "^0.2.10", - "@definitelytyped/typescript-versions": "^0.1.2", - "@definitelytyped/utils": "^0.1.6", + "@definitelytyped/header-parser": "^0.2.11", + "@definitelytyped/typescript-versions": "^0.1.3", + "@definitelytyped/utils": "^0.1.7", "@types/node": "^18.19.39", "@types/react": "18.2.55", "@types/react-dom": "18.3.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 87d7e4702063ed..58f456057090d7 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -13,9 +13,9 @@ overrides: '@babel/preset-typescript': ^7.24.7 '@babel/runtime': ^7.24.7 '@babel/types': ^7.24.7 - '@definitelytyped/header-parser': ^0.2.10 - '@definitelytyped/typescript-versions': ^0.1.2 - '@definitelytyped/utils': ^0.1.6 + '@definitelytyped/header-parser': ^0.2.11 + '@definitelytyped/typescript-versions': ^0.1.3 + '@definitelytyped/utils': ^0.1.7 '@types/node': ^18.19.39 '@types/react': 18.2.55 '@types/react-dom': 18.3.0 @@ -10526,6 +10526,7 @@ packages: engines: {node: '>=0.6.0', teleport: '>=0.2.0'} deprecated: |- You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. + (For a CapTP with native promises, see @endo/eventual-send and @endo/captp) qjobs@1.2.0: From fea558d8b7cc930245ab9e5a1962896d3383e910 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aar=C3=B3n=20Garc=C3=ADa=20Herv=C3=A1s?= Date: Sun, 30 Jun 2024 16:20:13 +0200 Subject: [PATCH 2/2] [core] Remove react-test-renderer (#42784) --- packages-internal/test-utils/package.json | 2 -- .../test-utils/src/describeConformance.tsx | 18 ------------- packages/mui-base/src/Menu/Menu.test.tsx | 2 +- .../src/MenuButton/MenuButton.test.tsx | 2 +- .../mui-base/src/MenuItem/MenuItem.test.tsx | 5 +--- packages/mui-base/src/Modal/Modal.test.tsx | 5 +--- packages/mui-base/src/Option/Option.test.tsx | 5 +--- packages/mui-base/src/Popper/Popper.test.tsx | 6 +---- packages/mui-base/src/Select/Select.test.tsx | 2 +- packages/mui-base/src/Tab/Tab.test.tsx | 5 +--- .../mui-base/src/TabPanel/TabPanel.test.tsx | 5 +--- .../mui-base/src/TabsList/TabsList.test.tsx | 5 +--- .../src/Unstable_Popup/Popup.test.tsx | 6 +---- .../test/describeConformanceUnstyled.tsx | 2 -- .../src/Autocomplete/Autocomplete.test.tsx | 7 +----- packages/mui-joy/src/Drawer/Drawer.test.tsx | 1 - packages/mui-joy/src/Menu/Menu.test.tsx | 1 - .../src/MenuButton/MenuButton.test.tsx | 2 +- .../mui-joy/src/MenuItem/MenuItem.test.tsx | 2 +- packages/mui-joy/src/Modal/Modal.test.tsx | 1 - packages/mui-joy/src/Select/Select.test.tsx | 9 +------ packages/mui-joy/src/Tab/Tab.test.tsx | 2 +- packages/mui-joy/src/TabList/TabList.test.tsx | 2 +- .../mui-joy/src/TabPanel/TabPanel.test.tsx | 2 +- packages/mui-joy/src/Table/Table.test.tsx | 1 - packages/mui-joy/src/Tabs/Tabs.test.tsx | 2 +- packages/mui-joy/src/Tooltip/Tooltip.test.tsx | 2 -- packages/mui-lab/src/TabList/TabList.test.js | 2 -- .../mui-lab/src/TabPanel/TabPanel.test.tsx | 8 +----- .../src/Autocomplete/Autocomplete.test.js | 2 +- .../src/Backdrop/Backdrop.test.js | 7 +----- .../mui-material/src/Dialog/Dialog.test.js | 8 +----- .../mui-material/src/Drawer/Drawer.test.js | 8 +----- packages/mui-material/src/Fade/Fade.test.js | 3 --- packages/mui-material/src/Grow/Grow.test.js | 2 -- packages/mui-material/src/Menu/Menu.test.js | 1 - packages/mui-material/src/Modal/Modal.test.js | 1 - .../mui-material/src/Popover/Popover.test.js | 1 - .../mui-material/src/Popper/Popper.test.js | 2 -- packages/mui-material/src/Slide/Slide.test.js | 2 -- .../src/Snackbar/Snackbar.test.js | 8 +----- .../src/SpeedDial/SpeedDial.test.js | 1 - .../SpeedDialAction/SpeedDialAction.test.js | 2 +- .../src/StepContent/StepContent.test.js | 2 +- .../SwipeableDrawer/SwipeableDrawer.test.js | 9 +------ .../mui-material/src/Tooltip/Tooltip.test.js | 2 -- packages/mui-material/src/Zoom/Zoom.test.js | 2 -- pnpm-lock.yaml | 25 ------------------- renovate.json | 2 +- scripts/useReactVersion.mjs | 2 +- 50 files changed, 30 insertions(+), 176 deletions(-) diff --git a/packages-internal/test-utils/package.json b/packages-internal/test-utils/package.json index e5e97a96411abc..81b2bbc52d6abd 100644 --- a/packages-internal/test-utils/package.json +++ b/packages-internal/test-utils/package.json @@ -49,7 +49,6 @@ "mocha": "^10.4.0", "playwright": "^1.44.1", "prop-types": "^15.8.1", - "react-test-renderer": "^18.2.0", "sinon": "^16.1.3" }, "devDependencies": { @@ -59,7 +58,6 @@ "@types/prop-types": "^15.7.12", "@types/react": "^18.2.55", "@types/react-dom": "^18.3.0", - "@types/react-test-renderer": "^18.3.0", "@types/sinon": "^17.0.3", "typescript": "^5.4.5" }, diff --git a/packages-internal/test-utils/src/describeConformance.tsx b/packages-internal/test-utils/src/describeConformance.tsx index 6d5ee641d3c37c..b1c2dfc0dbc382 100644 --- a/packages-internal/test-utils/src/describeConformance.tsx +++ b/packages-internal/test-utils/src/describeConformance.tsx @@ -1,7 +1,6 @@ /* eslint-env mocha */ import * as React from 'react'; import { expect } from 'chai'; -import ReactTestRenderer from 'react-test-renderer'; import createDescribe from './createDescribe'; import { MuiRenderResult } from './createRenderer'; @@ -246,22 +245,6 @@ export function testRootClass( }); } -/** - * Tests that the component can be rendered with react-test-renderer. - * This is important for snapshot testing with Jest (even if we don't encourage it). - */ -export function testReactTestRenderer(element: React.ReactElement) { - it('should render without errors in ReactTestRenderer', () => { - ReactTestRenderer.act(() => { - ReactTestRenderer.create(element, { - createNodeMock: (node) => { - return document.createElement(node.type as keyof HTMLElementTagNameMap); - }, - }); - }); - }); -} - function forEachSlot( slots: ConformanceOptions['slots'], callback: (slotName: string, slot: SlotTestingOptions) => void, @@ -1018,7 +1001,6 @@ const fullSuite = { propsSpread: testPropsSpread, refForwarding: describeRef, rootClass: testRootClass, - reactTestRenderer: testReactTestRenderer, slotPropsProp: testSlotPropsProp, slotPropsCallback: testSlotPropsCallback, slotsProp: testSlotsProp, diff --git a/packages/mui-base/src/Menu/Menu.test.tsx b/packages/mui-base/src/Menu/Menu.test.tsx index 5d25dda325e20d..f5dd5b9cd3ba50 100644 --- a/packages/mui-base/src/Menu/Menu.test.tsx +++ b/packages/mui-base/src/Menu/Menu.test.tsx @@ -53,7 +53,7 @@ describe('', () => { expectedClassName: menuClasses.listbox, }, }, - skip: ['reactTestRenderer', 'componentProp', 'slotsProp'], + skip: ['componentProp', 'slotsProp'], })); describe('after initialization', () => { diff --git a/packages/mui-base/src/MenuButton/MenuButton.test.tsx b/packages/mui-base/src/MenuButton/MenuButton.test.tsx index 26658177f8fc9d..ee213658e70dd2 100644 --- a/packages/mui-base/src/MenuButton/MenuButton.test.tsx +++ b/packages/mui-base/src/MenuButton/MenuButton.test.tsx @@ -37,7 +37,7 @@ describe('', () => { testWithElement: null, }, }, - skip: ['componentProp', 'reactTestRenderer'], + skip: ['componentProp'], })); describe('prop: disabled', () => { diff --git a/packages/mui-base/src/MenuItem/MenuItem.test.tsx b/packages/mui-base/src/MenuItem/MenuItem.test.tsx index 3f3efa09059d80..1ee75a22aa7b61 100644 --- a/packages/mui-base/src/MenuItem/MenuItem.test.tsx +++ b/packages/mui-base/src/MenuItem/MenuItem.test.tsx @@ -37,9 +37,6 @@ describe('', () => { expectedClassName: menuItemClasses.root, }, }, - skip: [ - 'componentProp', - 'reactTestRenderer', // Need to be wrapped in MenuContext - ], + skip: ['componentProp'], })); }); diff --git a/packages/mui-base/src/Modal/Modal.test.tsx b/packages/mui-base/src/Modal/Modal.test.tsx index c1f1bff8348230..291a16c734a646 100644 --- a/packages/mui-base/src/Modal/Modal.test.tsx +++ b/packages/mui-base/src/Modal/Modal.test.tsx @@ -29,10 +29,7 @@ describe('', () => { expectedClassName: classes.root, }, }, - skip: [ - 'componentProp', - 'reactTestRenderer', // portal https://github.com/facebook/react/issues/11565 - ], + skip: ['componentProp'], }), ); diff --git a/packages/mui-base/src/Option/Option.test.tsx b/packages/mui-base/src/Option/Option.test.tsx index 36eae126b0cc04..9eb8a58d86d4e0 100644 --- a/packages/mui-base/src/Option/Option.test.tsx +++ b/packages/mui-base/src/Option/Option.test.tsx @@ -38,9 +38,6 @@ describe('