Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Missing "Area Chart" icon #39874

Closed
bentaly opened this issue Nov 13, 2023 · 9 comments · Fixed by #45020
Closed

[icons] Missing "Area Chart" icon #39874

bentaly opened this issue Nov 13, 2023 · 9 comments · Fixed by #45020
Assignees
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: icons Specific to @mui/icons

Comments

@bentaly
Copy link

bentaly commented Nov 13, 2023

Steps to reproduce 🕹

Link to live example:

As you can see there is an icon called "Area Chart"
https://fonts.google.com/icons?icon.set=Material+Icons&selected=Material+Icons+Outlined:area_chart:&icon.query=area+chart

This doe not exist on the mui.com icons demo (or in the package):
https://mui.com/material-ui/material-icons/?query=area

Current behavior 😯

It appears some icons are missing - even thought mui.com says:
"@mui/icons-material includes the 2,100+ official Material Icons"

Expected behavior 🤔

No response

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo

  System:
    OS: macOS 14.1
  Binaries:
    Node: 20.5.1 - ~/.local/share/asdf/installs/nodejs/20.5.1/bin/node
    Yarn: Not Found
    npm: 9.8.0 - ~/.local/share/asdf/plugins/nodejs/shims/npm
  Browsers:
    Chrome: 119.0.6045.123
    Edge: Not Found
    Safari: 17.1
  npmPackages:
    @emotion/react: ^11.11.1 => 11.11.1 
    @emotion/styled: ^11.11.0 => 11.11.0 
    @mui/base:  5.0.0-beta.23 
    @mui/core-downloads-tracker:  5.14.17 
    @mui/icons-material: ^5.14.16 => 5.14.16 
    @mui/material: ^5.14.17 => 5.14.17 
    @mui/private-theming:  5.14.17 
    @mui/styled-engine:  5.14.17 
    @mui/system:  5.14.17 
    @mui/types:  7.2.8 
    @mui/utils:  5.14.17 
    @types/react: ^18.2.15 => 18.2.36 
    react: ^18.2.0 => 18.2.0 
    react-dom: ^18.2.0 => 18.2.0 
    typescript: ^5.0.2 => 5.2.2 
@bentaly bentaly added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 13, 2023
@zannager zannager added the package: icons Specific to @mui/icons label Nov 13, 2023
@mj12albert
Copy link
Member

@bentaly Thanks for reporting this, I believe the icons package needs to be synced once in a while with the official Material Icons: https://github.com/mui/material-ui/tree/master/packages/mui-icons-material#contributing

Would you be interested in creating a PR?

@mj12albert mj12albert added enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 20, 2023
@mj12albert mj12albert changed the title material-icons has missing icons [icons] Missing "Area Chart" icon Nov 20, 2023
@bentaly
Copy link
Author

bentaly commented Nov 20, 2023

Hi @mj12albert thanks for letting me know.
I'll have a look into this when I get some time, thanks!

@PaulKristoffersson
Copy link
Contributor

@bentaly I made a PR to fix it for you, hope that is ok! @mj12albert I followed the instructions in the link you provided.

@bentaly
Copy link
Author

bentaly commented Nov 21, 2023

@PaulKristoffersson No problem and thanks! good luck with the MR, I was getting around to it :)

@bentaly
Copy link
Author

bentaly commented Dec 8, 2023

Hi @mj12albert - is anyone able to take a look at the associated MR?

@bentaly
Copy link
Author

bentaly commented Jan 8, 2024

Hi all, just wondering if anyone approved can take a look at that PR? Going to have to switch to another icon version of Mui icons if not

@siriwatknp
Copy link
Member

@bentaly I could not find the area_chart from https://fonts.google.com/metadata/icons?incomplete=true. Our script could not detect the icon.

For a workaround, you can download the SVG from https://fonts.gstatic.com/s/i/materialiconsround/area_chart/v3/24px.svg and use it like this:

import SvgIcon from '@mui/material/SvgIcon';

<SvgIcon>
  <svg></SvgIcon>

@siriwatknp siriwatknp added external dependency Blocked by external dependency, we can’t do anything about it and removed enhancement This is not a bug, nor a new feature labels Feb 20, 2024
@bentaly
Copy link
Author

bentaly commented Feb 20, 2024

Thanks @siriwatknp I'm aware I can add work-arounds and then remove them when the library is updated - I just had assumed given it's featured on the mui website that it would be relatively up to date.
But thanks for the work around idea

Copy link

github-actions bot commented Feb 7, 2025

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@bentaly How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency Blocked by external dependency, we can’t do anything about it package: icons Specific to @mui/icons
Projects
None yet
5 participants