From e7f4846dea2df153f49f09f67088538b62cd3154 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 23 Jul 2019 16:50:56 +0200 Subject: [PATCH 1/6] Fix react-select using no space in regression test --- docs/src/pages/components/autocomplete/IntegrationReactSelect.js | 1 + .../src/pages/components/autocomplete/IntegrationReactSelect.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/src/pages/components/autocomplete/IntegrationReactSelect.js b/docs/src/pages/components/autocomplete/IntegrationReactSelect.js index 9e5a8c48c7fae0..f23a05f575699b 100644 --- a/docs/src/pages/components/autocomplete/IntegrationReactSelect.js +++ b/docs/src/pages/components/autocomplete/IntegrationReactSelect.js @@ -55,6 +55,7 @@ const useStyles = makeStyles(theme => ({ root: { flexGrow: 1, height: 250, + minWidth: 290, }, input: { display: 'flex', diff --git a/docs/src/pages/components/autocomplete/IntegrationReactSelect.tsx b/docs/src/pages/components/autocomplete/IntegrationReactSelect.tsx index 859dbca50080dc..a177ad6dc3d669 100644 --- a/docs/src/pages/components/autocomplete/IntegrationReactSelect.tsx +++ b/docs/src/pages/components/autocomplete/IntegrationReactSelect.tsx @@ -69,6 +69,7 @@ const useStyles = makeStyles((theme: Theme) => root: { flexGrow: 1, height: 250, + minWidth: 290, }, input: { display: 'flex', From 7167cc1e303a56e9046ba87841dcfc6564472877 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 23 Jul 2019 17:04:29 +0200 Subject: [PATCH 2/6] Fixup customization route change --- test/regressions/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/regressions/index.js b/test/regressions/index.js index b04977859621a3..d7fb7602bcaf19 100644 --- a/test/regressions/index.js +++ b/test/regressions/index.js @@ -32,6 +32,7 @@ const blacklistSuite = [ 'docs-discover-more-languages', // Needs interaction + 'docs-components-click-away-listener', 'docs-components-dialogs', 'docs-components-menus', 'docs-components-tooltips', @@ -62,7 +63,7 @@ const blacklistFilename = [ 'docs-components-steppers/SwipeableTextMobileStepper.png', // external img 'docs-components-steppers/TextMobileStepper.png', // external img 'docs-getting-started-usage/Usage.png', // codesandbox iframe - 'docs-customization-themes/ResponsiveFontSizesChart.png', // Chart + 'docs-customization-typography/ResponsiveFontSizesChart.png', // Chart // Already tested once assembled 'docs-getting-started-page-layout-examples-dashboard/Chart.png', From 9eb548f899349824b3c69129c1e455c80ce4b041 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 23 Jul 2019 17:26:23 +0200 Subject: [PATCH 3/6] Fix certain regression demos taking no space --- docs/src/pages/components/tables/ReactVirtualizedTable.js | 2 +- docs/src/pages/components/tables/ReactVirtualizedTable.tsx | 2 +- .../pages/customization/typography/ResponsiveFontSizesChart.js | 2 +- docs/src/pages/system/positions/ZIndex.js | 2 +- docs/src/pages/system/positions/ZIndex.tsx | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.js b/docs/src/pages/components/tables/ReactVirtualizedTable.js index f45cfb6de9bd55..fb827a0b6cfe22 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.js +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.js @@ -152,7 +152,7 @@ for (let i = 0; i < 200; i += 1) { export default function ReactVirtualizedTable() { return ( - + rows[index]} diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx index 94d40fdefe9080..afcda6a7e97757 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx @@ -174,7 +174,7 @@ for (let i = 0; i < 200; i += 1) { export default function ReactVirtualizedTable() { return ( - + rows[index]} diff --git a/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js b/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js index 24055d04c372e5..9621c7adfd58be 100644 --- a/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js +++ b/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js @@ -20,8 +20,8 @@ const variants = ['h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'subtitle1']; const useStyles = makeStyles({ root: { + flexGrow: 1, height: 380, - width: '100%', color: 'black', }, }); diff --git a/docs/src/pages/system/positions/ZIndex.js b/docs/src/pages/system/positions/ZIndex.js index ebe3b5a0e826dc..b2dcc61fa55ce7 100644 --- a/docs/src/pages/system/positions/ZIndex.js +++ b/docs/src/pages/system/positions/ZIndex.js @@ -7,7 +7,7 @@ export default function ZIndex() { Date: Tue, 23 Jul 2019 17:27:23 +0200 Subject: [PATCH 4/6] Ignore container demos --- test/regressions/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/regressions/index.js b/test/regressions/index.js index d7fb7602bcaf19..5e3e9c1fc6c3d5 100644 --- a/test/regressions/index.js +++ b/test/regressions/index.js @@ -55,6 +55,9 @@ const blacklistSuite = [ 'docs-versions', 'docs-layouts', 'docs-customization-color', + + // low value + 'docs-components-container', ]; const blacklistFilename = [ From acdcf5aa4ec23e9998339476ca475ab4e80849c7 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 23 Jul 2019 17:49:02 +0200 Subject: [PATCH 5/6] Inline styles issue? --- .../components/tables/ReactVirtualizedTable.js | 13 +++++++++++-- .../components/tables/ReactVirtualizedTable.tsx | 13 +++++++++++-- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.js b/docs/src/pages/components/tables/ReactVirtualizedTable.js index fb827a0b6cfe22..ba6e7e8373ea83 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.js +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.js @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import clsx from 'clsx'; -import { withStyles } from '@material-ui/core/styles'; +import { makeStyles, withStyles } from '@material-ui/core/styles'; import TableCell from '@material-ui/core/TableCell'; import Paper from '@material-ui/core/Paper'; import { AutoSizer, Column, Table } from 'react-virtualized'; @@ -150,9 +150,18 @@ for (let i = 0; i < 200; i += 1) { rows.push(createData(i, ...randomSelection)); } +const useDemoStyles = makeStyles({ + root: { + height: 400, + flexGrow: 1, + }, +}); + export default function ReactVirtualizedTable() { + const classes = useDemoStyles(); + return ( - + rows[index]} diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx index afcda6a7e97757..033c30add50393 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx @@ -1,6 +1,6 @@ import React from 'react'; import clsx from 'clsx'; -import { createStyles, Theme, withStyles, WithStyles } from '@material-ui/core/styles'; +import { createStyles, makeStyles, Theme, withStyles, WithStyles } from '@material-ui/core/styles'; import TableCell from '@material-ui/core/TableCell'; import Paper from '@material-ui/core/Paper'; import { AutoSizer, Column, Table, TableCellRenderer, TableHeaderProps } from 'react-virtualized'; @@ -172,9 +172,18 @@ for (let i = 0; i < 200; i += 1) { rows.push(createData(i, ...randomSelection)); } +const useDemoStyles = makeStyles({ + root: { + height: 400, + flexGrow: 1, + }, +}); + export default function ReactVirtualizedTable() { + const classes = useDemoStyles(); + return ( - + rows[index]} From 548945e465b8596a77c7e248513676efaf15f134 Mon Sep 17 00:00:00 2001 From: Sebastian Silbermann Date: Tue, 23 Jul 2019 18:15:56 +0200 Subject: [PATCH 6/6] Keep no space demos to be notified when it works --- .../components/tables/ReactVirtualizedTable.js | 13 ++----------- .../components/tables/ReactVirtualizedTable.tsx | 13 ++----------- .../typography/ResponsiveFontSizesChart.js | 2 +- docs/src/pages/system/positions/ZIndex.js | 2 +- docs/src/pages/system/positions/ZIndex.tsx | 2 +- test/regressions/index.js | 3 --- 6 files changed, 7 insertions(+), 28 deletions(-) diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.js b/docs/src/pages/components/tables/ReactVirtualizedTable.js index ba6e7e8373ea83..f45cfb6de9bd55 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.js +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.js @@ -1,7 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import clsx from 'clsx'; -import { makeStyles, withStyles } from '@material-ui/core/styles'; +import { withStyles } from '@material-ui/core/styles'; import TableCell from '@material-ui/core/TableCell'; import Paper from '@material-ui/core/Paper'; import { AutoSizer, Column, Table } from 'react-virtualized'; @@ -150,18 +150,9 @@ for (let i = 0; i < 200; i += 1) { rows.push(createData(i, ...randomSelection)); } -const useDemoStyles = makeStyles({ - root: { - height: 400, - flexGrow: 1, - }, -}); - export default function ReactVirtualizedTable() { - const classes = useDemoStyles(); - return ( - + rows[index]} diff --git a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx index 033c30add50393..94d40fdefe9080 100644 --- a/docs/src/pages/components/tables/ReactVirtualizedTable.tsx +++ b/docs/src/pages/components/tables/ReactVirtualizedTable.tsx @@ -1,6 +1,6 @@ import React from 'react'; import clsx from 'clsx'; -import { createStyles, makeStyles, Theme, withStyles, WithStyles } from '@material-ui/core/styles'; +import { createStyles, Theme, withStyles, WithStyles } from '@material-ui/core/styles'; import TableCell from '@material-ui/core/TableCell'; import Paper from '@material-ui/core/Paper'; import { AutoSizer, Column, Table, TableCellRenderer, TableHeaderProps } from 'react-virtualized'; @@ -172,18 +172,9 @@ for (let i = 0; i < 200; i += 1) { rows.push(createData(i, ...randomSelection)); } -const useDemoStyles = makeStyles({ - root: { - height: 400, - flexGrow: 1, - }, -}); - export default function ReactVirtualizedTable() { - const classes = useDemoStyles(); - return ( - + rows[index]} diff --git a/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js b/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js index 9621c7adfd58be..24055d04c372e5 100644 --- a/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js +++ b/docs/src/pages/customization/typography/ResponsiveFontSizesChart.js @@ -20,8 +20,8 @@ const variants = ['h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'subtitle1']; const useStyles = makeStyles({ root: { - flexGrow: 1, height: 380, + width: '100%', color: 'black', }, }); diff --git a/docs/src/pages/system/positions/ZIndex.js b/docs/src/pages/system/positions/ZIndex.js index b2dcc61fa55ce7..ebe3b5a0e826dc 100644 --- a/docs/src/pages/system/positions/ZIndex.js +++ b/docs/src/pages/system/positions/ZIndex.js @@ -7,7 +7,7 @@ export default function ZIndex() {